Skip to content

ci: gate claim-link loading in press-contract (TASK-24599) - #4015

Open
Hugo0 wants to merge 1 commit into
devfrom
ci/24599-claim-link-gate
Open

Hugo0 wants to merge 1 commit into
devfrom
ci/24599-claim-link-gate

Conversation

@Hugo0

@Hugo0 Hugo0 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Make the claim-link load spec (e2e/flows/claim-link-load.spec.ts, merged in #4013) a step of the press-contract job.

Why: from phase 2 of TASK-24599 the API will return a send link's note and both people's identity only to a caller that sends a valid link-key proof. If an app change ever stops sending the proof, claim pages would quietly lose those fields. This step fails CI first. The spec passed 3/3 in CI on #4013 (run 42405501233).

Why a separate PR: it edits a workflow file, so the Backdoor guard needs a reader other than the author. Split out of #4013 so the feature could merge.

Change: one step in .github/workflows/tests.yml (press-contract) and the comment on its timeout (two specs → three). Adds about a minute to the job.

Risk: a flaky spec would hold press-contract; the spec answers the API with page.route stand-ins, so it has no network dependency. Rollback: revert.

TASK-24599: https://www.notion.so/41083811757981e69cd5ccceeb9af029

…s the app sending the link proof fails CI before the API refuses it (TASK-24599)
@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Nov 7, 2026 8:40pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR changes CI workflows or the backdoor scan itself

The scan in tests.yml runs this PR's own workflow, so a change here could switch it off. This check stays red until the change is merged. Someone other than the author must read these files before anyone runs the branch:

  • .github/workflows/tests.yml

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 11250.18 → 11250.18 (0)
Findings: 0 net (+0 new, -0 resolved)

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

No findings in the workflow change. The new spec uses the existing Playwright setup and press-contract remains a required CI job.

Checked clean

  • Exact head and merge base verified; the diff only adds the claim-link load spec step and updates the spec-count comment.
  • The spec exists on the base, uses the regression config and existing build/browser setup, and press-contract is already required by ci-success.
  • The guard failure is expected for a workflow edit under the base-branch backdoor-guard policy; press-contract was still building when checked.

Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.

Exact head: 73e4f6b8ca21 · Context: repo · Took 3m

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • ✅ unit: 19157 ran, 0 failed, 0 skipped, 6.1m

📊 Coverage (unit)

metric %
statements 87.6%
branches 80.3%
functions 81.8%
lines 89.0%
⏱ 10 slowest test cases
time test
🐢 16.5s scripts/__tests__/screens-adapter.test.js › runs the existing synthetic screen adapter Node acceptance suite
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
🐢 5.0s scripts/__tests__/signup-attribution-paths.test.ts › includes newly published articles and locale fallbacks without editing the manifest
🐢 5.0s scripts/__tests__/indexable-urls.test.ts › excludes missing locale files, drafts, redirects, and retired pages from crawl and submission lists
4.0s src/features/setup/__tests__/useSignupPasskey.test.tsx › opens the help drawer for NotReadableError and retries from it with one more ceremony
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_RECENT_REFUND fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › User KYC not approved fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_SOURCE_OVER_MONTHLY_CAP fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › routes the KYC rejection on its wire code, and does not retry it
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_VOLUME_NEAR_CAP fails fast with copy that names the real cause
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

This branch was successfully deployed

1 active deployment
Preview — 73e4f6b8 Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant