Repository navigation
Conversation
…s the app sending the link proof fails CI before the API refuses it (TASK-24599)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Code-analysis diffPainscore total: 11250.18 → 11250.18 (0) |
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings in the workflow change. The new spec uses the existing Playwright setup and press-contract remains a required CI job.
Checked clean
- Exact head and merge base verified; the diff only adds the claim-link load spec step and updates the spec-count comment.
- The spec exists on the base, uses the regression config and existing build/browser setup, and press-contract is already required by ci-success.
- The guard failure is expected for a workflow edit under the base-branch backdoor-guard policy; press-contract was still building when checked.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: 73e4f6b8ca21 · Context: repo · Took 3m
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Make the claim-link load spec (
e2e/flows/claim-link-load.spec.ts, merged in #4013) a step of thepress-contractjob.Why: from phase 2 of TASK-24599 the API will return a send link's note and both people's identity only to a caller that sends a valid link-key proof. If an app change ever stops sending the proof, claim pages would quietly lose those fields. This step fails CI first. The spec passed 3/3 in CI on #4013 (run 42405501233).
Why a separate PR: it edits a workflow file, so the Backdoor guard needs a reader other than the author. Split out of #4013 so the feature could merge.
Change: one step in
.github/workflows/tests.yml(press-contract) and the comment on its timeout (two specs → three). Adds about a minute to the job.Risk: a flaky spec would hold
press-contract; the spec answers the API withpage.routestand-ins, so it has no network dependency. Rollback: revert.TASK-24599: https://www.notion.so/41083811757981e69cd5ccceeb9af029