Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 27, 2026
peterxcli
added this pull request to stack #28
September 27, 2026 13:20
peterxcli
force-pushed
the
HDDS-16325-chunk-range-readers
branch
from
October 1, 2026 05:30
a8b2d03 to
1bd38ac
Compare
…ange-readers # Conflicts: # hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkInputStream.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reuse a chunk range reader instead of creating a temporary ChunkInputStream for each positioned read. It handles checksum alignment and range copying, while each request owns its client reference. Local reads use the existing FileChannel path.
Part 2 of 3, based on #23 and replacing #24: #23 → this PR → #25. Concurrent EC and encrypted multipart reads are inherited from #23; streaming positioned reads come from apache#11314.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16325
How was this patch tested?
The complete stack passed 158 focused unit tests and nine integration cases, including checksum-verified local reads, EC reads, encrypted multipart reads, and vectored reads. Checkstyle and RAT passed. KMS integration required the JDK 21 JAXB access flag documented in #23.
Generated-by: Codex (GPT-6)