Pass Escape if permanent insert mode is active#4896
Open
hron wants to merge 1 commit into
Open
Conversation
Many web pages handle `Escape` to dismiss an editable input field, e.g. Todoist's "Quick Add" or YouTube Music's search field. Before this change when a user hits `Escape` Todoist doesn't dismiss the dialog, the same happens with YouTube Music and probably many more web apps. With this improvement everything works as expected.
hron
force-pushed
the
pass-escape-in-permanent-insert-mode
branch
from
938db65 to
41432c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many web pages handle
Escapeto dismiss an editable input field, e.g. Todoist's "Quick Add" or YouTube Music's search field. Before this change Vimium when a user hitsEscapeTodoist doesn't dismiss the dialog, the same happens with YouTube Music and probably many more web apps. With this improvement everything works as expected.Demo
Before
vimium-before.webm
After
vimium-after.webm