Fix DocBlockTagGrouping reporting a fix it never applied

[dereuromark]

checkBeginningOfDocBlock() guarded its fixer body with the condition inverted:

$fix = $phpcsFile->addFixableError(..., 'NoExtraNewlineBeforeTags');
if ($fix) {
    return;          // <- returns exactly when it should fix
}

$phpcsFile->fixer->beginChangeset();

addFixableError() returns true only while the fixer is running. So the changeset ran only when the fixer was disabled - a no-op - and phpcbf reported NoExtraNewlineBeforeTags as fixable and then changed nothing. Every other fixable error in the file uses if (!$fix) { return; }.

Found while writing the smoke fixtures in #73, which recorded the broken output:

    /**
     *
     * @var string
     */
    public const TAGS_START_TOO_LATE = 'start';

The fixture now records the blank line actually being removed.

[Copilot]

Pull request overview

Fixes a logic inversion in DocBlockTagGroupingSniff::checkBeginningOfDocBlock() that caused PHPCBF to report NoExtraNewlineBeforeTags as fixable but skip applying the actual fix, and updates the corresponding smoke fixture output to reflect the now-applied change.

Changes:

• Correct the fixable-error guard in checkBeginningOfDocBlock() by switching from if ($fix) { return; } to if (!$fix) { return; }.
• Update the DocBlockTagGrouping “after” fixture to remove the extra blank * line before tags, matching the fixed behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
PhpCollective/Sniffs/Commenting/DocBlockTagGroupingSniff.php	Fixes the inverted fixer guard so the changeset runs only when fixing is enabled.
tests/_data/DocBlockTagGrouping/after.php	Updates expected fixed output to reflect removal of the extra blank line before the first tag.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.