Change long2ip return type#13395
Merged
Merged
Conversation
Member
|
test failing on windows seem related |
Member
|
It fails because the assertion may be deleted and so the function call too. |
devnexen
reviewed
Feb 15, 2024
Member
|
Look ok otherwise. |
Member
|
Would it be possible to squash your commits ? |
Member
|
@devnexen It is possible to squash the commits on the GitHub UI. Since the MR looks good to me as well, I'll do it. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
inet_ntopcannot return false in the current usage, as was describedhttps://github.com/vimeo/psalm/pull/9537#discussion_r1140799451.