Cherry-pick https://github.com/lexbor/lexbor/commit/9181fce#22093
Open
kocsismate wants to merge 1 commit into
Open
Cherry-pick https://github.com/lexbor/lexbor/commit/9181fce#22093kocsismate wants to merge 1 commit into
kocsismate wants to merge 1 commit into
Conversation
Updating lexbor for php#22075
kocsismate
changed the title
TimWolla
approved these changes
May 19, 2026
ndossche
approved these changes
May 19, 2026
Member
|
Generally, updates should be done via https://github.com/php/php-src/blob/master/ext/lexbor/patches/update-lexbor.sh now. I think this should either get a patch, or we should update to the given version. Especially if for master only. |
Member
Author
|
@iluuu1994 Unfortunately, the required change has not been released yet. Thanks for highlighting the script, it was very difficult (for me at least) to update lexbor before. Are you OK if I go with the cherry-pick for now? |
Member
|
Any reason why this can't be added as a patch then? A future update would remove the change, though at least it would be obvious with a compiler error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating lexbor for #22075