Skip to content

fix filter reactivity - #97

Merged
jamesdabbs merged 1 commit into
mainfrom
jcd/reactive-filter
Dec 11, 2023
Merged

jamesdabbs merged 1 commit into
mainfrom
jcd/reactive-filter

Conversation

@jamesdabbs

@jamesdabbs jamesdabbs commented Dec 11, 2023 •

Copy link
Copy Markdown
Member

fixes #77

Testing Notes

For each of spaces, properties, theorems, explore page

  • Filtering updates the url query param
  • Reloading with a query param filters
  • Navigating away and then pressing back updates the page

@jamesdabbs jamesdabbs self-assigned this Dec 11, 2023
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 11, 2023 •

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e443ca
Status: ✅  Deploy successful!
Preview URL: https://b0b1bf27.topology.pages.dev
Branch Preview URL: https://jcd-reactive-filter.topology.pages.dev

View logs

@jamesdabbs
jamesdabbs marked this pull request as ready for review December 11, 2023 00:50
@jamesdabbs
jamesdabbs merged commit 195a606 into main Dec 11, 2023
@jamesdabbs
jamesdabbs deleted the jcd/reactive-filter branch December 11, 2023 00:53
jamesdabbs added a commit that referenced this pull request Dec 13, 2023
* format {S#|P#} display (#80)

to include a description of the trait value

* persist data source branch in localStorage (#89)

* persist data source branch in localStorage

* fix compile build failure

which appears to have been introduced through random dependency
drift, not any changes here :/

* cache cypress binary in CI

to fix https://github.com/pi-base/web/actions/runs/7149095438/job/19470902100?pr=89

* fix trait#show page reactivity (#94)

per report [here](https://github.com/orgs/pi-base/discussions/464#discussioncomment-7560692)

* truncate previews at first line break (#96)

* fix filter reactivity (#97)

fixes #77

* add related trait filter url param

* typeset internal links (#99)

* misc. minor style tweaks (#100)

- adjust icon styling
- fix spacing around ,s in alias lists
- correct table header style

* use action verbs in robot toggle (#103)

* Update homepage to promote code4math (#93)

* Update homepage to promote code4math

* typo, formatting

* formatting

* lint

* redirect to normalized ids

---------

Co-authored-by: Steven Clontz <steven.clontz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

navigating back to /spaces

1 participant