What — Small test-quality and observability cleanups from the latest audit, batched.
Scope —
modules/billing/tests/billing.migration.backfill-signup-grant.integration.tests.js: the test runs the real up() unscoped over the shared organizations collection (filtered only by plan) — leftover free-plan orgs from other test files silently get credited. Scope the migration run/assertions to the seeded fixture ids.modules/organizations/services/organizations.crud.service.js:128: the result.plan || 'free' fallback is unreachable (plan: 'free' is set unconditionally above) and its unit test forces the branch with a repository return shape the real repo cannot produce — drop the branch + test, or make the test realistic.isEnabledOAuthProvider (auth): rests on passport's private _strategy API and every test mocks/stubs it — add one test against a really-registered strategy so a passport upgrade that renames the private API fails in CI instead of silently 404-ing OAuth logins.modules/billing/migrations/20260707100000-backfill-missing-signup-grant-credits.js: the failed counter conflates plan-not-found, guard-stripped and genuine runtime errors (all null returns from grantOnSignup) — differentiate the three cases in the completion log.
Refs: internal audit 2026-07-16 (M3, L2, L3, L4).
Created via /dev:issue
What — Small test-quality and observability cleanups from the latest audit, batched.
Scope —
modules/billing/tests/billing.migration.backfill-signup-grant.integration.tests.js: the test runs the realup()unscoped over the sharedorganizationscollection (filtered only by plan) — leftover free-plan orgs from other test files silently get credited. Scope the migration run/assertions to the seeded fixture ids.modules/organizations/services/organizations.crud.service.js:128: theresult.plan || 'free'fallback is unreachable (plan: 'free'is set unconditionally above) and its unit test forces the branch with a repository return shape the real repo cannot produce — drop the branch + test, or make the test realistic.isEnabledOAuthProvider(auth): rests on passport's private_strategyAPI and every test mocks/stubs it — add one test against a really-registered strategy so a passport upgrade that renames the private API fails in CI instead of silently 404-ing OAuth logins.modules/billing/migrations/20260707100000-backfill-missing-signup-grant-credits.js: thefailedcounter conflates plan-not-found, guard-stripped and genuine runtime errors (allnullreturns fromgrantOnSignup) — differentiate the three cases in the completion log.Refs: internal audit 2026-07-16 (M3, L2, L3, L4).
Created via /dev:issue