chore(pull-request skill): forward stack-related review comments as upstream issues - #3189
Conversation
…pstream issues Add guardrail in section 6c: when a review comment targets a file from the upstream stack, create an issue on the stack repo instead of fixing it downstream. Reply with a link to the issue and resolve the thread. Closes #3180
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull-request skill's guidance for handling actionable comments (section 6c) has been expanded to differentiate between stack-originated and non-stack-originated files. Stack-originated files now trigger upstream issue creation with reply links and thread resolution, while non-stack files follow existing batch-fix procedures with commit citations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the /pull-request Claude skill guidance so that review findings on upstream stack-owned files are forwarded as upstream issues rather than being fixed in downstream stack update PRs.
Changes:
- Added a guardrail in section 6c describing how to handle review comments targeting stack-originated files.
- Clarified that non-stack actionable comments should still be fixed in a single batch (verify → commit → push → reply/resolve).
Use git cat-file against devkit-node/master remote to determine if a reviewed file belongs to the upstream stack.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3189 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 52 52
Lines 1166 1166
Branches 235 235
=======================================
Hits 1048 1048
Misses 107 107
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/skills/pull-request/SKILL.md:
- Around line 221-224: Update the "If the file is stack-originated:" block in
.claude/skills/pull-request/SKILL.md to explicitly specify the upstream repo
slug (use the devkit-node remote value `pierree-devkit/Node`) and show an
example GitHub CLI command that includes the --repo flag (i.e., demonstrate
using gh issue create --repo pierree-devkit/Node ...) so reviewers are
instructed to target the upstream repo rather than the default current repo;
ensure the step mentions deriving the slug from the devkit-node remote.
- Around line 215-219: The stack-file detection relies on the devkit-node remote
being present; add an explicit prerequisite note before section 6c
("prerequisite: run /update-stack first") or, better, add a defensive fetch
before the git check: run "git fetch devkit-node master" and handle fetch
failure (log a warning and fall back to downstream behavior) immediately before
executing the "git cat-file -e devkit-node/master:path/to/file" check so the
check uses an up-to-date ref; reference the existing check command and the
/update-stack skill in the update.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 90b96314-7501-4284-b538-d266bb2e9118
📒 Files selected for processing (1)
.claude/skills/pull-request/SKILL.md
…ack check - Fetch devkit-node/master before git cat-file to ensure ref is current - Derive upstream repo slug from remote URL - Use gh issue create --repo to target upstream repo explicitly - Document fallback behavior when remote is missing
Summary
Scope
.claude/skills/pull-request/nonelowValidation
npm run lintnpm testGuardrails check
.env*,secrets/**, keys, tokens)Notes for reviewers
Summary by CodeRabbit
Note: This is an internal process update with no direct end-user impact.