Skip to content

fix(prerender): normalize expected paths in tests for cross-platform compatibility #3668

Closed

Description

@PierreBrisorgueil

Reported by CodeRabbit on comes-io/montaine_vue#53.

Review comment

routeToOutputPath() uses node:path.join() which returns platform-native separators. The test assertions use hard-coded forward slashes and will fail on Windows.

File

src/lib/plugins/tests/prerender.spec.js — lines 77-103

Suggested fix

Use path.join() to build expected values instead of literal strings with forward slashes.

Activity

  1. PierreBrisorgueil commented on Mar 10, 2026

    @PierreBrisorgueil
    CollaboratorAuthor

    Not applicable to this repo.

    The referenced file src/lib/plugins/tests/prerender.spec.js does not exist in this codebase, and neither does src/lib/plugins/prerender.js. The prerender plugin was likely discussed or prototyped on a downstream project branch (feat/seo-static-generation) but was never merged into the stack.

    Closing as not applicable.

  2. PierreBrisorgueil commented on Mar 10, 2026

    @PierreBrisorgueil
    CollaboratorAuthor

    Reopening — the files do exist on master (added by #3660). Consolidated into #3672.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions