Skip to content

fix(config): rename billing.config.js to billing.development.config.js - #3895

Merged
PierreBrisorgueil merged 2 commits into
masterfrom
fix/config-billing-rename-development
Apr 7, 2026
Merged

PierreBrisorgueil merged 2 commits into
masterfrom
fix/config-billing-rename-development

Conversation

@PierreBrisorgueil

@PierreBrisorgueil PierreBrisorgueil commented Apr 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Scope

  • Modules impacted: billing
  • Cross-module impact: none
  • Risk level: low

Validation

  • npm run lint
  • npm run test:unit
  • npm run build
  • Manual checks done (if applicable)

Guardrails check

  • No secrets or credentials introduced (.env*, secrets/**, keys, tokens)
  • No risky rename/move of core stack paths
  • Changes remain merge-friendly for downstream projects
  • Tests added or updated when behavior changed

Notes for reviewers

  • Security considerations: none
  • Mergeability considerations: Pure rename + import update — no logic change
  • Follow-up tasks: Downstream projects using billing.config.js should rename to billing.development.config.js

Summary by CodeRabbit

  • Chores
    • Updated the billing configuration source to reference development environment settings. This change affects how billing plans, features, pricing details, promotional information, and badges are sourced and displayed in the billing interface.

@PierreBrisorgueil PierreBrisorgueil self-assigned this Apr 7, 2026
@PierreBrisorgueil
PierreBrisorgueil marked this pull request as ready for review April 7, 2026 16:27
Copilot AI review requested due to automatic review settings April 7, 2026 16:27
@coderabbitai

coderabbitai Bot commented Apr 7, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@PierreBrisorgueil has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 48 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 48 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c9acea9d-1ba9-4ddc-abd9-f8d071d8f5f5

📥 Commits

Reviewing files that changed from the base of the PR and between a32e37e and 162689d.

📒 Files selected for processing (3)
  • MIGRATIONS.md
  • src/modules/billing/config/billing.development.config.js
  • src/modules/billing/views/billing.pricing.view.vue

Walkthrough

The billing pricing view import is updated to reference the newly named development configuration file, aligning with the {module}.{env}.config.js naming convention. All functionality remains unchanged.

Changes

Cohort / File(s) Summary
Configuration Import Update
src/modules/billing/views/billing.pricing.view.vue
Updated import path from billing.config to billing.development.config to follow standardized naming convention.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

billing

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR addresses the core objectives from issue #3892: renames the config file to follow {module}.{env}.config.js convention and updates imports. However, a migration note entry for MIGRATIONS.md appears to be missing. Add a migration note entry to MIGRATIONS.md documenting the rename so downstream projects know to update their imports.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: renaming a config file and aligns with the changeset shown in the raw summary.
Description check ✅ Passed The PR description is comprehensive and follows the template with all required sections completed: summary, scope, validation, guardrails, and reviewer notes.
Out of Scope Changes check ✅ Passed The changeset contains only the file rename and import update directly related to issue #3892, with no extraneous changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/config-billing-rename-development

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (11bf797) to head (162689d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3895   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          30       30           
  Lines        1037     1037           
  Branches      254      254           
=======================================
  Hits         1030     1030           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the billing module’s pricing plans config file to match the repository’s module config naming convention ({module}.development.config.js) and updates the pricing view import accordingly.

Changes:

  • Updated billing.pricing.view.vue to import the renamed config file.
  • Added src/modules/billing/config/billing.development.config.js containing the static marketing plan definitions.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/modules/billing/views/billing.pricing.view.vue Updates the config import to the new filename.
src/modules/billing/config/billing.development.config.js Introduces the renamed billing module config file with plan definitions.

import { useBillingStore } from '../stores/billing.store';
import { useAuthStore } from '../../auth/stores/auth.store';
import plansConfig from '../config/billing.config';
import plansConfig from '../config/billing.development.config';

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pricing view default-imports the module config file, but module config defaults are also consumed by the config generator via the file’s default export. Consider importing the plans via a named export (and keeping the file’s default export as an object for generateConfig.js), so this view isn’t coupled to the generator’s expected export shape.

Suggested change
import plansConfig from '../config/billing.development.config';
import { plans as plansConfig } from '../config/billing.development.config';

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2741b5d — switched to named import { plans as plansConfig } as suggested.

Comment on lines 87 to 90
import { useBillingStore } from '../stores/billing.store';
import { useAuthStore } from '../../auth/stores/auth.store';
import plansConfig from '../config/billing.config';
import plansConfig from '../config/billing.development.config';
import billingPricingToggleComponent from '../components/billing.pricingToggle.component.vue';

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #3892 mentions adding a MIGRATIONS.md note for downstream projects about the billing.config.js → billing.development.config.js rename, but this PR doesn’t include any migration documentation update (and MIGRATIONS.md currently has no billing-specific entry). Please add an explicit migration entry so downstream overrides/imports can be updated reliably.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2741b5d — added a 'Billing config rename' section to MIGRATIONS.md documenting the rename and the import update required for downstream projects.

@PierreBrisorgueil
PierreBrisorgueil force-pushed the fix/config-billing-rename-development branch from 2741b5d to 162689d Compare April 7, 2026 16:48
@PierreBrisorgueil
PierreBrisorgueil merged commit 22a5178 into master Apr 7, 2026
6 checks passed
@PierreBrisorgueil
PierreBrisorgueil deleted the fix/config-billing-rename-development branch April 7, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(config): rename billing.config.js to billing.development.config.js

2 participants