fix(auth): surface requestJoin failures in the org-setup alert (#4389)

[PierreBrisorgueil]

Problem

requestJoin() in organizationSetup.component.vue only logged on failure — never set this.error, so the existing inline v-alert never rendered when a join request failed (network error, duplicate, permission). Sibling submit() handles it correctly.

Fix

Mirror submit(): this.error = null at the top of requestJoin() (clears a stale create-org error) and, in the catch, this.error = err?.response?.data?.message || err?.message || 'Could not send join request. Please try again.'. Dropped the console.error to match submit(). No template change.

Test

The component test mock exposed only createOrganization (so any requestJoin test threw before the catch). Added createJoinRequest to the mock + 7 tests: success, requestSent emit, failure→server message, fallback to err.message, generic fallback, stale-error clear, no-suggested-org guard.

Also (issue nit 2)

The never-committed, untracked src/lib/helpers/api.js + its test (which carried downstream references and were dead code) were deleted from the working tree — they were never on master, so nothing to change here; noted for the tracker.

Closes #4389

https://claude.ai/code/session_01V1mhCDsSUnn3WGtevd3YFX

[coderabbitai]

Warning

Review limit reached

@PierreBrisorgueil, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: eb3c21b6-e785-4f60-bca3-1c7655f11a0e

📥 Commits

Reviewing files that changed from the base of the PR and between eb97682 and 0b8ef02.

📒 Files selected for processing (2)

• src/modules/auth/components/organizationSetup.component.vue
• src/modules/auth/tests/auth.organizationSetup.component.unit.tests.js

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/requestjoin-error-surface

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.56%. Comparing base (4bc2515) to head (0b8ef02).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4397   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          35       35           
  Lines        1390     1390           
  Branches      435      435           
=======================================
  Hits         1384     1384           
  Misses          6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.