Release 6.5.6 hotfix 20260720 by ChenNingjie1218 · Pull Request #10993 · pingcap/tiflash

ChenNingjie1218 · 2026-07-20T08:55:29Z

What problem does this PR solve?

Issue Number: ref #10337

Problem Summary:

Backport the exchange sender memory usage limit from #10387 to the v6.5.6 hotfix baseline for HF-1041.

This PR is opened only to trigger upstream GitHub CI for the hotfix and should not be merged.

What is changed and how it works?

Add max_buffered_bytes_in_executor and propagate it to DAG/MPP response writers.
Flush buffered rows by byte threshold to limit exchange sender memory usage.
Add/adapt unit tests for streaming and MPP exchange writers.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit 0bd20e8)

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit ffb2f0a)

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit 71b271f)

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit e8d4a5e)

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit 9ae2aee)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 45bacf0)

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit b798acf)

ti-chi-bot · 2026-07-20T08:55:32Z

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

It must be LGTMed and approved by the reviewers firstly.
For pull requests to TiDB-x branches, it must have no failed tests.
AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-07-20T08:55:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lidezhu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-07-20T08:55:39Z

Hi @ChenNingjie1218. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-07-20T08:55:45Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)

release-8.5
release-7.5
release-8.1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 74af9a90-35a9-459a-ba43-f2db384650c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

ChenNingjie1218 · 2026-07-20T08:56:25Z

/test pull-unit-test

ti-chi-bot · 2026-07-20T08:56:42Z

@ChenNingjie1218: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kumailf · 2026-07-20T09:12:20Z

/ok-to-test

wuhuizuo · 2026-07-21T07:00:55Z

/retest

wuhuizuo · 2026-07-21T07:19:14Z

/test pull-integration-test

wuhuizuo · 2026-07-21T08:52:59Z

/test pull-integration-test

ChenNingjie1218 · 2026-07-21T09:44:27Z

/test pull-integration-test

kumailf · 2026-07-22T02:46:40Z

/test pull-integration-test

kumailf · 2026-07-22T10:36:43Z

/test pull-integration-test

…back (#4849) ## Summary Unblock `release-6.5` TiFlash `pull_integration_test` (e.g. pingcap/tiflash#10993): 1. **Untagged `tiflash-ci-base` rewrite** `release-6.5` yamls still use `hub.pingcap.net/tiflash/tiflash-ci-base` without a tag. Existing rocky8/rocky9 sed rules miss it, so compose hits the retired registry. Add a sed rule mapping the untagged form to `TIFLASH_TEST_IMAGE` (`ghcr.io/pingcap-qe/cd/builders/tiflash:v20231106`). 2. **TiDB failpoint image fallback** (from closed #4845) If `tidb-server:release-6.5-failpoint` cannot be pulled, fall back to the regular `release-6.5` TiDB image for compose rewrites, and skip `tidb-ci/fail-point-tests` (requires a real failpoint binary). ## Test plan - [ ] Merge this PR - [ ] On pingcap/tiflash#10993, run `/test pull-integration-test` - [ ] Confirm no `hub.pingcap.net` pull for `tics0` / `tiflash-ci-base` - [ ] If failpoint tag is missing: logs show WARN fallback + skip fail-point-tests; other suites still run - [ ] If failpoint tag exists: pull succeeds and fail-point-tests still run

kumailf · 2026-07-29T04:38:27Z

/test pull-integration-test

) ## Summary Follow-up to #4849. Rewriting untagged `tiflash-ci-base` to `cd/builders/tiflash:v20231106` unblocked registry pulls, but fullstack tests exec into that container and need `mysql` client: ```text /bin/sh: mysql: command not found ``` Old `hub.pingcap.net/tiflash/tiflash-ci-base` included mysql (see `jenkins/Dockerfile/release/linux-amd64/tiflash_ci_base`). Builder images do not. ## Change - Pull `ghcr.io/pingcap-qe/bases/tiflash-base:v1.9.1` - Locally build `tiflash-ci-base-local:with-mysql` with `yum install -y mysql` (same recipe as historical Dockerfile) - Use that image for compose rewrites of `tiflash-ci-base` / `tics` Keeps failpoint fallback from #4849. ## Test plan - [ ] Merge and re-run `/test pull-integration-test` on pingcap/tiflash#10993 - [ ] Confirm prepare logs show building `tiflash-ci-base-local:with-mysql` - [ ] Confirm `fullstack-test/sample.test` no longer fails on `mysql: command not found`

kumailf · 2026-07-29T06:56:00Z

/test pull-integration-test

kumailf · 2026-07-29T07:52:05Z

/test pull-integration-test

…4852) ## Summary Follow-up after #4849 / #4850. `tidb-ci/cluster.yaml` on release-6.5 uses `qa/tidb:...-failpoint`. The previous logic only skipped `fail-point-tests` when the failpoint image **pull failed**. OCI still has `tidb-server:release-6.5-failpoint`, so pull succeeds, but the image does not expose `enableTestAPI`: ```text Error: get fail/github.com/pingcap/tidb/server/enableTestAPI ``` ## Change - Always fall back `TIDB_FAILPOINT_IMAGE` → regular `release-6.5` TiDB image - Always strip `./run-test.sh tidb-ci/fail-point-tests &&` from `run.sh` - Other suites (`fullstack-test`, async_grpc, collation, …) still run ## Test plan - [ ] Merge and `/test pull-integration-test` on pingcap/tiflash#10993 - [ ] Logs show WARN skip fail-point-tests - [ ] `tidb-ci` proceeds to fullstack-test without enableTestAPI error

kumailf · 2026-07-29T08:46:09Z

/test pull-integration-test

ti-chi-bot · 2026-07-29T09:25:22Z

@ChenNingjie1218: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-integration-test	`4c92aff`	link	true	`/test pull-integration-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ChenNingjie1218 · 2026-07-29T09:55:04Z

/test pull-integration-test

windtalker and others added 12 commits July 20, 2026 12:05

save work

78d68db

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit 0bd20e8)

save work

2195742

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit ffb2f0a)

refine

e7d49c7

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit 71b271f)

add tests

5e4f443

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit e8d4a5e)

format

7c87aeb

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit 9ae2aee)

Update dbms/src/Flash/Coprocessor/DAGUtils.cpp

8be7113

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 45bacf0)

save work

2c29866

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit b798acf)

Fix v6.5.11 hotfix build

c43866b

Fix GmSSL build on glibc

d03fdcf

Fix magic_enum TaskType build with clang

306431e

Suppress magic_enum enum conversion warning

a9d96e1

Fix aarch64 release version startup

4c92aff

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jul 20, 2026

ti-chi-bot Bot added contribution This PR is from a community contributor. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 20, 2026

ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 20, 2026

kumailf mentioned this pull request Jul 22, 2026

fix(pipelines): fallback when release-6.5 tidb failpoint image missing PingCAP-QE/ci#4845

Closed

3 tasks

kumailf mentioned this pull request Jul 28, 2026

fix(pipelines/tiflash): release-6.5 IT image rewrite + failpoint fallback PingCAP-QE/ci#4849

Merged

5 tasks

kumailf mentioned this pull request Jul 29, 2026

fix(pipelines/tiflash): release-6.5 IT runtime needs mysql client PingCAP-QE/ci#4850

Merged

3 tasks

kumailf mentioned this pull request Jul 29, 2026

fix(pipelines/tiflash): always skip fail-point-tests on release-6.5 PingCAP-QE/ci#4852

Merged

3 tasks

Uh oh!

Conversation

ChenNingjie1218 commented Jul 20, 2026

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot Bot commented Jul 20, 2026

Uh oh!

ti-chi-bot Bot commented Jul 20, 2026

Uh oh!

ti-chi-bot Bot commented Jul 20, 2026

Uh oh!

coderabbitai Bot commented Jul 20, 2026

Review skipped

Uh oh!

ChenNingjie1218 commented Jul 20, 2026

Uh oh!

ti-chi-bot Bot commented Jul 20, 2026

Uh oh!

kumailf commented Jul 20, 2026

Uh oh!

wuhuizuo commented Jul 21, 2026

Uh oh!

wuhuizuo commented Jul 21, 2026

Uh oh!

wuhuizuo commented Jul 21, 2026

Uh oh!

ChenNingjie1218 commented Jul 21, 2026

Uh oh!

kumailf commented Jul 22, 2026

Uh oh!

kumailf commented Jul 22, 2026

Uh oh!

kumailf commented Jul 29, 2026

Uh oh!

kumailf commented Jul 29, 2026

Uh oh!

kumailf commented Jul 29, 2026

Uh oh!

kumailf commented Jul 29, 2026

Uh oh!

ti-chi-bot Bot commented Jul 29, 2026

Uh oh!

ChenNingjie1218 commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants