tests: Fix foreign key tests with tidb configs - #11029
Merged
Merged
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
do-not-merge/work-in-progress
JaySon-Huang
marked this pull request as ready for review
August 10, 2026 07:35
ti-chi-bot
Bot
added
size/S
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change removes Docker Compose version declarations from classic YAML test configurations, updates fullstack and TiDB CI links to those configurations, and suppresses Rust deprecation warnings for selected LLVM builds. ChangesClassic YAML migration
Rust warning suppression
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
approved
needs-1-more-lgtm
JinheLin
approved these changes
Aug 10, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
Author
|
/test pull-integration-test |
12 tasks
Contributor
Author
|
/test pull-integration-test |
ti-chi-bot
Bot
added
size/M
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/tidb-ci/cluster.yaml`:
- Line 1: Update the tidb-ci/cluster.yaml symlink to target the
fail-point-enabled cluster composition instead of classic-yaml/cluster.yaml,
preserving the tidb0 image and environment required by tidb-ci/fail-point-tests.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9f27e552-2d2b-45e0-b8d1-6151d3044486
📒 Files selected for processing (23)
tests/docker/classic-yaml/cluster.yamltests/docker/classic-yaml/cluster_disable_new_collation.yamltests/docker/classic-yaml/cluster_new_collation.yamltests/docker/classic-yaml/cluster_tidb_fail_point.yamltests/docker/classic-yaml/tiflash-dt-disable-encrypt.yamltests/docker/classic-yaml/tiflash-dt-disable-local-tunnel.yamltests/docker/classic-yaml/tiflash-dt-force-enable-lm.yamltests/docker/classic-yaml/tiflash-dt-lightweight-compression.yamltests/docker/classic-yaml/tiflash-dt-sync-grpc.yamltests/docker/classic-yaml/tiflash-dt.yamltests/fullstack-test/cluster.yamltests/fullstack-test/tiflash-dt-sync-grpc.yamltests/fullstack-test/tiflash-dt.yamltests/fullstack-test2/cluster.yamltests/fullstack-test2/tiflash-dt-disable-encrypt.yamltests/fullstack-test2/tiflash-dt-disable-local-tunnel.yamltests/fullstack-test2/tiflash-dt.yamltests/tidb-ci/cluster.yamltests/tidb-ci/cluster_disable_new_collation.yamltests/tidb-ci/cluster_new_collation.yamltests/tidb-ci/tiflash-dt-force-enable-lm.yamltests/tidb-ci/tiflash-dt-lightweight-compression.yamltests/tidb-ci/tiflash-dt.yaml
💤 Files with no reviewable changes (10)
- tests/docker/classic-yaml/cluster.yaml
- tests/docker/classic-yaml/cluster_new_collation.yaml
- tests/docker/classic-yaml/tiflash-dt-force-enable-lm.yaml
- tests/docker/classic-yaml/tiflash-dt-disable-encrypt.yaml
- tests/docker/classic-yaml/cluster_disable_new_collation.yaml
- tests/docker/classic-yaml/tiflash-dt.yaml
- tests/docker/classic-yaml/tiflash-dt-sync-grpc.yaml
- tests/docker/classic-yaml/tiflash-dt-lightweight-compression.yaml
- tests/docker/classic-yaml/tiflash-dt-disable-local-tunnel.yaml
- tests/docker/classic-yaml/cluster_tidb_fail_point.yaml
Contributor
Author
|
/test pull-integration-test |
2 similar comments
Contributor
Author
|
/test pull-integration-test |
Contributor
Author
|
/test pull-integration-test |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
force-pushed
the
fix_fk_test
branch
from
August 11, 2026 03:01
b385fee to
b516fe4
Compare
Contributor
Author
|
/test pull-integration-test |
1 similar comment
Contributor
Author
|
/test pull-integration-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11028
Problem Summary: after pingcap/tidb#70328, tiflash integration tests failed
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit