[Bug]: Sidebar does not follow active thread after Cmd+[ / Cmd+] (back/forward) navigation #16534

Activity

1. juliusmarminge commented on Oct 6, 2026

   

   juliusmarminge

   on Oct 6, 2026

   Member

   More actions

   Note

   Grok responding on behalf of Julius.

   Triage

   Thanks @WarutC for the clear repro. Reading current main (b38aa18365), which matches the 0.0.45 build in the report, I don't see a duplicate. navigation.back / navigation.forward only call history.back() / history.forward() (NavigationHistoryShortcuts in apps/web/src/components/AppSidebarLayout.tsx). Highlight is route-driven: a row that is actually rendered gets the active style whenever its key matches the route, including after history navigation.

   What I found

   • Some cases already follow the route.
     • Default sidebar (legacy sidebar off): a settled thread past "Show more" is inserted into the visible tail when it is the open route, and a collapsed Working, Snoozed, or Settled shelf still renders the open thread's row. sidebarThreadPreviewCount (default 6) is unused here; the settled page starts at 10.
     • Legacy sidebar (Settings → Legacy features → Sidebar): a collapsed project still renders the open thread as that project's only row. The project header stays collapsed.
   • Two gaps are real, and they're shared by every route change, including the command palette. A click only looks correct when that row was already on screen.
     1. Default sidebar project scope. filterSidebarV2VisibleThreads drops every thread outside the scoped project, with no exception for the open route. setSidebarProjectScopeKey runs from the scope menu, the "filter by project" context-menu item, and when a saved scope's project disappears. Going back to a thread in another project leaves the filter in place, so the row isn't rendered and there's nothing to highlight. Pinning doesn't bypass that filter.
     2. Legacy sidebar, project expanded, thread past the preview count, "show more" not opened. The rendered list is the preview slice (sidebarThreadPreviewCount, default 6). The open thread isn't added.
   • No scroll-into-view. Neither sidebar scrolls the active row into view. The only scrollIntoView in the thread sidebar is for search results, so a row that exists below the fold stays off screen after history navigation.

   Likely fix area

   Sidebar route follow / filterSidebarV2VisibleThreads and the legacy preview slice. Some options:

   • For a scoped project filter, either widen the scope when the open thread is outside it, or keep the filter and still show the open row (what the shelves already do).
   • In the legacy sidebar, include the open thread in the preview list when it sits past sidebarThreadPreviewCount.
   • Scroll the active row into view on route change, not only for search results.

   Which sidebar was on, and which of those two gaps you hit, would help pin the fix.

   A maintainer will decide on the fix direction.
2. juliusmarminge

   added

   bugSomething is broken or behaving incorrectly.Something is broken or behaving incorrectly.

   via-triageFiled through npx t3 triageFiled through npx t3 triage

   on Oct 6, 2026
3. WarutC commented on Oct 6, 2026

   

   WarutC

   on Oct 6, 2026

   Author

   More actions

   Thanks for the triage. To answer the questions: I'm on the default (non-legacy) sidebar.

   With "All projects" selected, the highlight is correct after Cmd+[ / Cmd+], so I did not hit the scope-filter gap in practice. What I would still confirm is the missing scroll-into-view for rows below the fold. The single-project scope case follows from your reading of filterSidebarV2VisibleThreads, but I haven't tested it myself.

   Separately, back/forward stopping on the Settings page is a different bug, so I filed it on its own: #16542.
4. juliusmarminge commented on Oct 22, 2026

   

   juliusmarminge

   on Oct 22, 2026 – with GitCafe Production

   Member

   More actions

   Reproduced on main a12d6ed942 using the web dev server in Chromium on Linux, 1280×800, with two isolated fixture projects and eight threads each. Ctrl+[ / Ctrl+] exercise the Linux back/forward bindings.

   • New sidebar: opened A8, then B8, filtered to B, pressed Back. The main pane returned to A8 while the sidebar kept the B filter and omitted A8. Forward returned to B8. Recording.
   • Legacy sidebar, preview count 6: opened A1 via Show more, switched to B8, clicked Show less for A, pressed Back. The main pane returned to A1 while A1 remained hidden. Recording.
   • Collapsed legacy project: Back revealed the active row beneath its collapsed header on this commit.

   No duplicate found among 949 open issues. macOS/Electron shortcut handling is unverified here.
5. juliusmarminge

   closed this as completedin #23519on Oct 22, 2026