Before submitting
Area
apps/web
Steps to reproduce
- Open a mergeable pull request in the PR detail panel.
- Make the panel narrow enough that the header buttons collapse to icon only (
@max-[30rem]/pr-header).
- Click the header Merge button (or Enable auto-merge) once.
Expected behavior
The button visibly shows that it is armed and a second click will merge, even in its icon-only form.
Actual behavior
Since #17710, the first click arms the button and the only visible change is the label switching to "Confirm merge?" / "Confirm auto-merge?". In the compact header that label is hidden (@max-[30rem]/pr-header:hidden in PullRequestDetailPanel.tsx), so the button looks unchanged. Apart from the hover tooltip, nothing tells you a second click is needed, and the armed state expires after 3 seconds. The first click looks like it did nothing.
Approve workflows and the menu items are not affected because their labels never hide.
Impact
Minor bug or occasional failure
Version or commit
main @ 1f093d1 (#17710) and later
Proposed fix
Show the armed state in a way that survives the icon-only form. For example, swap the merge glyph for a confirm icon (e.g. CheckIcon) while armed, alongside the existing label change. Revert already switches to the destructive variant when armed, which would be another option. The change is limited to those two buttons in PullRequestDetailPanel.tsx. I'm happy to open a PR once the direction is approved.
Before submitting
Area
apps/web
Steps to reproduce
@max-[30rem]/pr-header).Expected behavior
The button visibly shows that it is armed and a second click will merge, even in its icon-only form.
Actual behavior
Since #17710, the first click arms the button and the only visible change is the label switching to "Confirm merge?" / "Confirm auto-merge?". In the compact header that label is hidden (
@max-[30rem]/pr-header:hiddeninPullRequestDetailPanel.tsx), so the button looks unchanged. Apart from the hover tooltip, nothing tells you a second click is needed, and the armed state expires after 3 seconds. The first click looks like it did nothing.Approve workflows and the menu items are not affected because their labels never hide.
Impact
Minor bug or occasional failure
Version or commit
main @ 1f093d1 (#17710) and later
Proposed fix
Show the armed state in a way that survives the icon-only form. For example, swap the merge glyph for a confirm icon (e.g.
CheckIcon) while armed, alongside the existing label change. Revert already switches to thedestructivevariant when armed, which would be another option. The change is limited to those two buttons inPullRequestDetailPanel.tsx. I'm happy to open a PR once the direction is approved.