Skip to content

[Bug]: PR review hides final files when diffs are collapsed; expanding the bottom file reveals them #18227

Open

Description

@AndreiShenets

ℹ️ Written by GPT-6.1 Sol on behalf of AndreiShenets

Before submitting

  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.

Area

apps/web — PR review Code tab, observed in the Windows desktop nightly app.

Summary

In a PR with many changed files, the collapsed diff list does not expose the last files. Expanding the bottom visible file makes the remaining file headers visible. The files are present in the right-hand Files tree throughout.

Steps to reproduce

  1. Open the desktop nightly app and open a PR with many changed files. The reported example has 43 files.
  2. Open the PR's Code tab with All commits selected.
  3. Collapse the file diffs and scroll the main diff list to the bottom.
  4. Observe that the main list ends before the final files shown in the right-hand Files tree.
  5. Expand the bottom visible file and scroll down again. The previously hidden file headers become visible below it.

The supplied screenshots show all 43 files marked viewed. Whether viewed state is necessary to reproduce is unknown.

Expected behavior

Every changed file header should be reachable in the main PR diff list, including when all file diffs are collapsed. Expanding a preceding file should not be necessary to reveal later files.

Actual behavior

With the file diffs collapsed, the bottom visible header is tests/CodeAnalysis.CSharp.Tests/StructuralHonestyTests/RefType/HostTests.cs. The subsequent SafetyTests.cs and TypeParameterList/OwnershipTests.cs headers are not visible in the main list, although both files are visible in the Files tree.

After expanding RefType/HostTests.cs, those two later headers become visible below its diff.

This report concerns visibility/scroll layout in the PR review UI, not patch-byte truncation. The root cause has not been established.

Impact

Major degradation or frequent failure — prevents reviewing the final files in the collapsed-list state without a workaround.

Version or commit

0.0.46-nightly.20261011.2967 (confirmed from the running desktop executable's file version).

Environment

Windows desktop, T3 Code Nightly. Display scaling and exact Windows version were not collected.

Screenshots, recordings, or supporting files

Two reporter-provided PNGs were inspected when preparing this report; the images themselves still need to be attached to this issue:

  • File trancation.png: Code tab, All commits, 43 files / 43 viewed. The collapsed main diff list ends at RefType/HostTests.cs; the Files tree also shows SafetyTests.cs and TypeParameterList/OwnershipTests.cs.
  • Files become visible when expanding the bottom one.png: RefType/HostTests.cs is expanded, and the two previously hidden headers are now visible beneath it.

Workaround

Expand the bottom visible file diff, then scroll down to reach the remaining file headers.

Image Image

Activity

  1. juliusmarminge commented on Oct 11, 2026

    @juliusmarminge
    Member

    Note

    Grok responding on behalf of Julius.

    Needs a retest on a newer nightly — and the screenshots never landed on the issue.

    You reported against 0.0.46-nightly.20261011.2967 (published 08:07 UTC). Guided reviews (#18124) merged later the same day (09:58 UTC) and changed the shared StyledDiffCodeView separator/virtualizer geometry that the PR Code tab uses. Please try again on the latest Nightly with a large PR, diffs collapsed, All commits selected.

    Also attach the two PNGs named in the report (File trancation.png and Files become visible when expanding the bottom one.png). Without them we cannot judge how far the list falls short.

    Notes from a quick code pass (not a confirmed root cause):

    If it still reproduces on latest Nightly with screenshots, comment and we will reopen investigation. If it does not, we can close this.

  2. AndreiShenets commented on Oct 11, 2026

    @AndreiShenets
    Author

    The nightly build is the latest, no new updates. The scrrenshots are pasted inside the bug

  3. AndreiShenets commented on Oct 11, 2026

    @AndreiShenets
    Author

    ℹ️ Written by GPT-6.1 Sol on behalf of AndreiShenets

    Confirming that the collapsed-file-list visibility issue still reproduces on the current Windows desktop nightly: 0.0.46-nightly.20261011.2980.

    The version was verified from the running desktop executable's file version. It matches the latest published nightly, v0.0.46-nightly.20261011.2980, published on October 11, 2026 at 14:37:21 UTC, and is newer than the originally reported .2967 build.

    The reporter's new screenshots show the PR Code tab with All commits, 19 files, and 0 / 19 viewed, with the file diffs collapsed:

    • Full.png shows all 19 headers, ending with tests/CodeAnalysis.CSharp.Tests/StructuralHonestyTests/TypeParameterConstraintClause/TriviaTests.cs.
    • Truncated.png shows the smaller viewport with the scrollbar at the bottom. The list stops at TypeParameterConstraintClause/Tests.cs; the subsequent TypeParameterConstraintClause/TriviaTests.cs header is not reachable in that view.

    This also demonstrates that marking the files viewed is not required for the reported visibility problem. The new screenshots compare full and truncated views; they do not document the expand-bottom-file workaround from the original report.

    Image Image
  4. AndreiShenets commented on Oct 17, 2026

    @AndreiShenets
    Author

    @juliusmarminge @maria-rcks please take a look to the PR for this bug. The fix looks very small when the bug is very irritating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs more infoInitial triage showed no bug. Awaiting more infovia-triageFiled through npx t3 triage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions