Skip to content

[Bug]: Keyboard shortcuts react to both physical and layout-derived keys #4434

Description

@neominik

Before submitting

  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.

Area

apps/desktop

Steps to reproduce

  1. Set your keyboard layout to a non-QWERTY layout.
  2. Notice that pressing both the physical and layout-derived keys trigger the same action. An example on my layout: Both physical Cmd+D (which maps to Cmd+A) and layout-derived Cmd+D (which is triggered by the physical key Cmd+L) trigger the action.

Expected behavior

I can use Cmd+A to select all text as well as Cmd+D to toggle the diff view. Only layout-derived keys should trigger shortcuts.

Actual behavior

As long as I want to use Cmd+D as a shortcut for anything, I cannot use Cmd+A to select text. There is no way to not consume some key if the physical key happens to map to some other key that I want to use as a shortcut.

This has been introduced somewhat recently, probably, see #2189 (comment). Mapping both physical and layout-derived keys probably sounds like a good idea (best of both worlds) until you actually use a different layout and can no longer use specific system shortcuts.

Impact

Major degradation or frequent failure

Version or commit

main @ 202e560

Environment

macOS 26.5.2

Logs or stack traces

Screenshots, recordings, or supporting files

No response

Workaround

No response

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or behaving incorrectly.needs-triageIssue needs maintainer review and initial categorization.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions