open keybindings.json complains about cursor if it is not installed

[tuncb]

I assume there should be another way of opening the json file, if cursor is not installed.
OS: windows.

[antiisaint]

Do you have any other editors that show within "open" in the chat header?

[Ymit24]

Some context from looking through the code: This happens when you haven’t yet used an editor, so no local storage lastEditor, and so the app defaults to cursor as fallback, not considering if it is an available editor. The OpenInPicker, from chat header, has access to available editors so it can give you real options or be disabled when none are available. It may be desirable to either pass available editors into the preferredTerminalEditor helper function so it chooses a more appropriate fallback, or otherwise unify the open in editor flows.

Note: this bug likely also occurs when opening link from chat markdown, opening file in diff view, opening file from toast, and maybe one or two other places.

I had the same thing happen to me so I’ve been looking at these code paths recently 😅

[Ymit24]

Created a possible fix for this bug and submitted PR. Should resolve this issue and similar associated issues 👍 .

[Ymit24]

the recently merged #662 should resolve this issue. This is probably good to close now 👍