Skip to content

fix(web): center pull request unavailable states #11110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Sep 11, 2026
Merged

fix(web): center pull request unavailable states #11110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e8393
fix(web): center pull request unavailable states
maria-rcks Sep 10, 2026
32232ea
fix(web): omit empty pull request header space
maria-rcks Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,13 @@ export function PullRequestDetailPanel({
onPickerOpenChange={setThreadPickerOpen}
/>
) : null}
<div className="@container/pr-header grid min-w-0 shrink-0 grid-cols-[minmax(0,1fr)_auto] items-start gap-x-2 border-b border-border/60">
<div
className={cn(
"@container/pr-header grid min-w-0 shrink-0 grid-cols-[minmax(0,1fr)_auto] items-start gap-x-2",
detail && "border-b border-border/60",
!detail && !onClose && "hidden",
)}
>
<div className="ml-4 grid h-7 min-w-0 items-center overflow-hidden">
<div
aria-hidden={condensed}
Expand Down Expand Up @@ -2519,7 +2525,7 @@ export function PullRequestDetailPanel({
</div>

<div
className="relative min-h-0 flex-1 overflow-hidden"
className="relative flex min-h-0 flex-1 flex-col overflow-hidden"
onScrollCapture={(event) => {
const scroller = event.target as HTMLElement;
scrollerRef.current = scroller;
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/pullRequest/PullRequestsUnavailableState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function PullRequestsUnavailableState({
gitHubUrl?: string;
}) {
return (
<Empty className="px-4 py-16 md:px-4">
<Empty className="min-h-0 justify-center-safe overflow-y-auto px-4 py-16 md:px-4 [&>*]:shrink-0">
<EmptyMedia variant="icon">
<GitPullRequestIcon />
</EmptyMedia>
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/routes/_chat.pull-requests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2360,7 +2360,7 @@ function PullRequestsColumn({
{/* The top padding is the shared fade band's height, the same pairing the
settings page makes: at rest the controls sit fully below the mask, and only
content actually passing under the chrome fades. */}
<WorkspacePageContainer width="expanded" className="gap-4">
<WorkspacePageContainer width="expanded" className="min-h-full gap-4">
<div className="flex flex-col gap-3">
<div ref={inFlowSearchRef} className="flex flex-wrap items-center gap-2">
<div className="min-w-0 basis-full @lg/pr-list:basis-0 @lg/pr-list:flex-1">
Expand Down
Loading