fix(desktop): prevent startup from running twice

apps/desktop/scripts/main-process-bundle.test.mjs

@@ -0,0 +1,110 @@
+import * as NodeFSP from "node:fs/promises";
+import * as NodeOS from "node:os";
+import * as NodePath from "node:path";
+import * as NodeVM from "node:vm";
+import { build } from "vite-plus/pack";
+import { assert, it } from "vite-plus/test";
+
+import desktopConfig from "../vite.config.ts";
+
+it("keeps lazy Linux imports and worker bundles from executing desktop startup twice", async () => {
+  const directory = await NodeFSP.mkdtemp(NodePath.join(NodeOS.tmpdir(), "t3-desktop-bundle-"));
+  try {
+    const workerEntries = [
+      "src/electron/WindowsForegroundFocusWorker.ts",
+      "src/snapShot/GlobalShiftShortcutWorker.ts",
+      "src/snapShot/RegionSnapShotWorker.ts",
+      "src/snapShot/SnapShotAccessibilityWorker.ts",
+    ];
+    await Promise.all([
+      NodeFSP.mkdir(NodePath.join(directory, "src/electron"), { recursive: true }),
+      NodeFSP.mkdir(NodePath.join(directory, "src/snapShot"), { recursive: true }),
+    ]);
+    await Promise.all([
+      NodeFSP.writeFile(
+        NodePath.join(directory, "src/main.ts"),
+        `import { shared } from "./shared.ts";
+process.emit("startup", shared.value);
+void import("./linux.ts").then(({ result }) => process.emit("ready", result));`,
+      ),
+      NodeFSP.writeFile(
+        NodePath.join(directory, "src/shared.ts"),
+        "export const shared = { value: 42 };",
+      ),
+      NodeFSP.writeFile(
+        NodePath.join(directory, "src/linux.ts"),
+        'import { shared } from "./shared.ts"; export const result = shared.value + 1;',
+      ),
+      ...workerEntries.map((entry) =>
+        NodeFSP.writeFile(
+          NodePath.join(directory, entry),
+          'import { shared } from "../shared.ts"; process.emit("worker", shared.value);',
+        ),
+      ),
+    ]);
+    assert.ok(Array.isArray(desktopConfig.pack));
+    const fixtureEntries = new Set(["src/main.ts", ...workerEntries]);
+    for (const packConfig of desktopConfig.pack) {
+      if (!Array.isArray(packConfig.entry)) continue;
+      if (!packConfig.entry.some((entry) => fixtureEntries.has(entry))) continue;
+      await build({
+        ...packConfig,
+        config: false,
+        cwd: directory,
+        tsconfig: false,
+        sourcemap: false,
+        onSuccess: undefined,
+        logLevel: "silent",
+      });
+    }
+
+    const outputDirectory = NodePath.join(directory, "dist-electron");
+    const filenames = (await NodeFSP.readdir(outputDirectory, { recursive: true })).filter(
+      (filename) => filename.endsWith(".cjs"),
+    );
+    const sources = new Map(
+      await Promise.all(
+        filenames.map(async (filename) => {
+          const path = NodePath.join(outputDirectory, filename);
+          return [path, await NodeFSP.readFile(path, "utf8")];
+        }),
+      ),
+    );
+    const modules = new Map();
+    const startups = [];
+    const workers = [];
+    const ready = Promise.withResolvers();
+    const load = (filename, cacheModule = true) => {
+      const cached = modules.get(filename);
+      if (cached) return cached.exports;
+      const module = { exports: {} };
+      if (cacheModule) modules.set(filename, module);
+      const source = sources.get(filename);
+      assert.ok(source, `Missing bundle: ${filename}`);
+      NodeVM.runInNewContext(source, {
+        exports: module.exports,
+        module,
+        require: (specifier) => load(NodePath.resolve(NodePath.dirname(filename), specifier)),
+        process: {
+          emit: (event, value) => {
+            if (event === "startup") startups.push(value);
+            if (event === "worker") workers.push(value);
+            if (event === "ready") ready.resolve(value);
+          },
+        },
+      });
+      return module.exports;
+    };
+
+    load(NodePath.join(outputDirectory, "main.cjs"), false);
+    assert.equal(await ready.promise, 43);
+    assert.deepEqual(startups, [42]);
+    for (const entry of workerEntries) {
+      load(NodePath.join(outputDirectory, entry.replace(/^src\//, "").replace(/\.ts$/, ".cjs")));
+    }
+    assert.deepEqual(workers, [42, 42, 42, 42]);
+    assert.deepEqual(startups, [42]);
+  } finally {
+    await NodeFSP.rm(directory, { recursive: true, force: true });
+  }
+});

apps/desktop/vite.config.ts

@@ -48,6 +48,23 @@ export default defineConfig({
     },
   },
   pack: [
+    {
+      format: "cjs",
+      outDir: "dist-electron",
+      dts: false,
+      sourcemap: true,
+      outExtensions: () => ({ js: ".cjs" }),
+      define: publicConfigDefine,
+      outputOptions: { codeSplitting: false },
+      entry: ["src/main.ts"],
+      clean: true,
+      deps: {
+        alwaysBundle: (id) => !id.startsWith("node:") && !isMainProcessExternal(id),
+        neverBundle: isMainProcessExternal,
+        onlyBundle: false,
+      },
+      ...(shouldLaunchElectronAfterPack ? { onSuccess: "node scripts/dev-electron.mjs" } : {}),
+    },
     {
       format: "cjs",
       outDir: "dist-electron",
@@ -56,19 +73,17 @@ export default defineConfig({
       outExtensions: () => ({ js: ".cjs" }),
       define: publicConfigDefine,
       entry: [
-        "src/main.ts",
         "src/electron/WindowsForegroundFocusWorker.ts",
         "src/snapShot/GlobalShiftShortcutWorker.ts",
         "src/snapShot/RegionSnapShotWorker.ts",
         "src/snapShot/SnapShotAccessibilityWorker.ts",
       ],
-      clean: true,
+      clean: false,
       deps: {
         alwaysBundle: (id) => !id.startsWith("node:") && !isMainProcessExternal(id),
         neverBundle: isMainProcessExternal,
         onlyBundle: false,
       },
-      ...(shouldLaunchElectronAfterPack ? { onSuccess: "node scripts/dev-electron.mjs" } : {}),
     },
     {
       format: "cjs",