Skip to content

fix(web): prevent duplicate quotes from dead keys #12644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SpizzyCoder wants to merge 1 commit into from
Closed

fix(web): prevent duplicate quotes from dead keys #12644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/web/src/components/ComposerPromptEditorTiptap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,18 @@ function ComposerPromptEditorTiptapInner(props: ComposerPromptEditorProps) {
return handled;
},
handleTextInput: (view, from, to, text) => {
// Dead keys can replace a composition range without a user selection.
// Only surround explicitly selected text; let native composition finish.
const selection = view.state.selection;
if (
view.composing ||
!(selection instanceof TextSelection) ||
selection.empty ||
selection.from !== from ||
selection.to !== to
) {
return false;
}
if (text.length !== 1) return false;
const closer = SURROUND_CLOSE[text];
if (!closer || from === to) return false;
Expand Down
Loading