Repository navigation
feat(web): keep resting composer controls inside the composer - #12841
maria-rcks wants to merge 4 commits into
Conversation
github-actions
Bot
added
vouch:trusted
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR substantially changes the production resting-composer experience, including control placement, responsive measurement and overflow, transitions, drag handling, and timeline spacing across multiple components. The scope and cross-component runtime impact exceed a minor self-contained UI adjustment. You can add or adjust custom eligibility rules. Learn more. |
|
Note Written by The base branch The same commit replayed on the current base is pushed as |
a1f8051 to
0337dd6
Compare
fe4f6ad to
87c67bd
Compare
juliusmarminge
added
the
macroscope-review
ChatGPT Codex Connector
juliusmarminge
added
the
triage:keep-open
The prompt row now starts the prompt from its reserved width and gives the controls cluster the row's shrink weight, so a picker the measurement allowed to contract does so before the prompt loses its reservation. Image previews sit beside the prompt as their own row item and the measurement reads them from the row. Mention drags landing on the inline controls or previews reach the composer's drop handling again; only the branch strip below the input and floating menus bypass it.
c775d2b to
0186b1b
Compare
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (13)
Comment |
github-actions
Bot
added
size:L
2 participants
the resting composer keeps model, effort, and mode beside the prompt. narrow layouts move controls into overflow while preserving branch context. removing the old strip also removes its portal, animation, and width measurements. the existing-thread guard prevents metadata effects from resetting a newly launched worktree.
verified at
7ae53636: 131 existing tests, scoped typechecks/lint, and two independent code approvals. real codex root and new-worktree turns completed with the expected branch and path. browser checks covered wheel collapse/expansion, pickers, attachment preview/removal, context retention, light/dark, phone width, and split-pane overflow.before/after use the same completed conversation at 1440×1000; the baseline is main
17c08789. isolated sidebar rows differ. attachment sending, native clients, remote connections, and animation smoothness remain unverified.original implementation: claude-fable-5-1 in claude code. simplification and verification: gpt-6.1-sol in codex through t3 code.