-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat(devices): offer manual updates in tool version details #12877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3456,13 +3456,15 @@ const makeWsRpcLayer = ( | |||||
| [WS_METHODS.deviceList]: (input) => | ||||||
| observeRpcEffect( | ||||||
| WS_METHODS.deviceList, | ||||||
| input.inspectOnly | ||||||
| input.inspectOnly && !input.updateTool | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Keep retry requests out of the inspection bypass. If a client sends Proposed fix- input.inspectOnly && !input.updateTool
+ input.inspectOnly && !input.updateTool && !input.retryHostId📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| ? deviceService.inspect | ||||||
| : authorizeEffect( | ||||||
| requiredScopeForDeviceList(input), | ||||||
| input.retryHostId | ||||||
| ? deviceService.retryHost(input.retryHostId) | ||||||
| : deviceService.list, | ||||||
| input.updateTool | ||||||
| ? deviceService.updateTool(input.updateTool) | ||||||
| : input.retryHostId | ||||||
| ? deviceService.retryHost(input.retryHostId) | ||||||
| : deviceService.list, | ||||||
| ), | ||||||
| { | ||||||
| "rpc.aggregate": "device", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unavailable capability, not a wrapped failure, so manufacturing an
Errorsolely to satisfyDeviceOperationError.causeloses the distinction required by the error convention. Use an existing cause-free structured availability error instead.Posted via Macroscope — Effect Service Conventions