refactor(web): add Alert sidebar variants and Kbd sizes - #13000
juliusmarminge wants to merge 1 commit into
Conversation
a4022c9 to
12fec60
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (12)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughChangesShared UI restyling
Restyle lint gate
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to This is a UI-only restyling change with no identified runtime, data, security, or availability impact, and is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
12fec60 to
5bba193
Compare
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized UI refactor that centralizes existing Alert and Kbd styling into reusable variants, with only small, explicit presentation changes in existing views. It introduces no schema, workflow, security-sensitive, deployment, or production-processing changes. Notes:
No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
465f914 to
2bb5571
Compare
Three sidebar alerts hand-rolled the same pill (rounded-2xl, warning/40 border, warning/8 fill) and one the same for a neutral notice; the thread error banner reached the alert-glass utility through className. Expose variant="sidebar-notice|sidebar-warning" and surface="glass" on Alert. Kbd gets size="xs|default|wide" and KbdGroup gap="loose" for the two recurring shapes. Visible effect: the two sidebar connection warnings in the legacy sidebar drop from text-sm to text-xs, matching the update pill beside them. Lowers the no-restyle ceiling from 949 to 911. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2bb5571 to
f246da1
Compare
Three sidebar alerts hand-rolled the same pill (rounded-2xl, warning/40
border, warning/8 fill) and one the same for a neutral notice; the thread
error banner reached the alert-glass utility through className. Expose
variant="sidebar-notice|sidebar-warning" and surface="glass" on Alert.
Kbd gets size="xs|default|wide" and KbdGroup gap="loose" for the two
recurring shapes.
Visible effect: the two sidebar connection warnings in the legacy sidebar
drop from text-sm to text-xs, matching the update pill beside them.
Lowers the no-restyle ceiling from 949 to 911.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit