Skip to content

chore(lint): exempt CollapsibleTrigger from no-restyle #13002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliusmarminge wants to merge 1 commit into from
Closed

chore(lint): exempt CollapsibleTrigger from no-restyle #13002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/lint-restyle-ceiling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import * as NodeURL from "node:url";
// components/ui exports are migrated to variants (see vite.config.ts). This gate keeps the
// count from growing: CI fails when findings exceed the ceiling. Lower the ceiling when you
// migrate a file, and delete this script when the rule becomes an error.
export const RESTYLE_CEILING = 911;
export const RESTYLE_CEILING = 842;

const RULE = "shadcn(no-restyle)";

Expand Down
16 changes: 15 additions & 1 deletion vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,21 @@ export default defineConfig({
files: ["apps/web/src/**"],
excludeFiles: ["apps/web/src/components/ui/**"],
rules: {
"shadcn/no-restyle": ["warn", { allow: ["layout"] }],
"shadcn/no-restyle": [
"warn",
{
allow: ["layout"],
contracts: [
{
// CollapsibleTrigger is a bare button with no styled counterpart
// (a disclosure row is not a Button), so its className is the API.
// Every other trigger has one: style them with render={<Button …/>}.
pattern: "^CollapsibleTrigger$",
allow: ["layout", "color", "typography", "spacing", "shape", "effects", "motion"],
},
],
},
],
},
},
{
Expand Down
Loading