Skip to content

fix(codex): Pro Max accounts load, so Ultrafast shows up #14304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3dotgg merged 2 commits into from
Sep 29, 2026
Merged

fix(codex): Pro Max accounts load, so Ultrafast shows up #14304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60356f5
fix(codex): Pro Max accounts load, so Ultrafast shows up
t3dotgg Sep 29, 2026
45333ae
fix(codex): shorter Ultrafast description that fits on one line
t3dotgg Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/server/src/provider/Layers/CodexProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ it("uses standard routing when the catalog has no default service tier", () => {
name: "Fast",
description: "1.5x speed, increased usage",
},
{
id: "ultrafast",
name: "Ultrafast",
description: "The fastest available responses for latency-sensitive work.",
},
],
supportedReasoningEfforts: [],
});
Expand All @@ -97,6 +102,11 @@ it("uses standard routing when the catalog has no default service tier", () => {
label: "Fast",
description: "1.5x speed, increased usage",
},
{
id: "ultrafast",
label: "Ultrafast",
description: "Even faster, more expensive",
},
],
currentValue: "default",
},
Expand Down
22 changes: 16 additions & 6 deletions apps/server/src/provider/Layers/CodexProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ const REASONING_EFFORT_LABELS: Readonly<Record<string, string>> = {

const DEFAULT_SERVICE_TIER_ID = "default";

/** Shorter copy for tiers whose catalog description wraps in the traits menu. */
const SERVICE_TIER_DESCRIPTIONS: Readonly<Record<string, string>> = {
ultrafast: "Even faster, more expensive",
};

function reasoningEffortLabel(reasoningEffort: string): string {
return REASONING_EFFORT_LABELS[reasoningEffort] ?? reasoningEffort;
}
Expand All @@ -115,6 +120,8 @@ export function codexPlanLabel(planType: string | null | undefined): string | un
return "ChatGPT Pro 20x Subscription";
case "prolite":
return "ChatGPT Pro 5x Subscription";
case "promax":
return "ChatGPT Pro Max Subscription";
case "team":
return "ChatGPT Team Subscription";
case "self_serve_business_prolite":
Expand Down Expand Up @@ -195,12 +202,15 @@ export function mapCodexModelCapabilities(
label: "Standard",
...(defaultServiceTier === DEFAULT_SERVICE_TIER_ID ? { isDefault: true } : {}),
},
...serviceTiers.map((tier) => ({
id: tier.id,
label: tier.name,
...(tier.description ? { description: tier.description } : {}),
...(defaultServiceTier === tier.id ? { isDefault: true } : {}),
})),
...serviceTiers.map((tier) => {
const description = SERVICE_TIER_DESCRIPTIONS[tier.id] ?? tier.description;
return {
id: tier.id,
label: tier.name,
...(description ? { description } : {}),
...(defaultServiceTier === tier.id ? { isDefault: true } : {}),
};
}),
],
currentValue: defaultServiceTier,
});
Expand Down
9 changes: 8 additions & 1 deletion packages/effect-codex-app-server/scripts/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,13 @@ const ManualSchemas: Record<string, Schema.Json> = {
},
};

// Codex adds plan slugs between our protocol refreshes (0.159 added `promax`).
// T3 Code only uses the plan for labels, so an unknown slug must not fail the
// whole `account/read` decode and take the provider down with it.
const DefinitionOverrides: Record<string, Schema.Json> = {
PlanType: { type: "string" },
};

const getGeneratedPaths = Effect.fn("getGeneratedPaths")(function* () {
const path = yield* Path.Path;
const generatedDir = path.join(import.meta.dirname, "..", "src", "_generated");
Expand Down Expand Up @@ -643,7 +650,7 @@ const generateFiles = Effect.fn("generateFiles")(function* () {
aggregateSchemas[localDefinitionNames.get(definitionName)!] = stripNullDefaults(
normalizeNullableTypes(
rewriteExternalRefs(
definitionSchema,
DefinitionOverrides[definitionName] ?? definitionSchema,
localDefinitionNames,
file.namespace,
exportNameByQualifiedName,
Expand Down
205 changes: 20 additions & 185 deletions packages/effect-codex-app-server/src/_generated/schema.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3204,43 +3204,10 @@ export const ServerNotification__AuthMode = Schema.Union(
identifier: "ServerNotification__AuthMode",
});

export type ServerNotification__PlanType =
| "free"
| "go"
| "plus"
| "pro"
| "prolite"
| "team"
| "self_serve_business_prolite"
| "self_serve_business_usage_based"
| "business"
| "ent26"
| "enterprise_cbp_automation"
| "enterprise_cbp_usage_based"
| "enterprise"
| "edu"
| "edu_plus"
| "edu_pro"
| "unknown";
export const ServerNotification__PlanType = Schema.Literals([
"free",
"go",
"plus",
"pro",
"prolite",
"team",
"self_serve_business_prolite",
"self_serve_business_usage_based",
"business",
"ent26",
"enterprise_cbp_automation",
"enterprise_cbp_usage_based",
"enterprise",
"edu",
"edu_plus",
"edu_pro",
"unknown",
]).annotate({ identifier: "ServerNotification__PlanType" });
export type ServerNotification__PlanType = string;
export const ServerNotification__PlanType = Schema.String.annotate({
identifier: "ServerNotification__PlanType",
});

export type ServerNotification__CreditsSnapshot = {
readonly balance?: string | null;
Expand Down Expand Up @@ -4138,43 +4105,10 @@ export const V2AccountRateLimitsUpdatedNotification__SpendControlLimitSnapshot =
used: Schema.String,
}).annotate({ identifier: "V2AccountRateLimitsUpdatedNotification__SpendControlLimitSnapshot" });

export type V2AccountRateLimitsUpdatedNotification__PlanType =
| "free"
| "go"
| "plus"
| "pro"
| "prolite"
| "team"
| "self_serve_business_prolite"
| "self_serve_business_usage_based"
| "business"
| "ent26"
| "enterprise_cbp_automation"
| "enterprise_cbp_usage_based"
| "enterprise"
| "edu"
| "edu_plus"
| "edu_pro"
| "unknown";
export const V2AccountRateLimitsUpdatedNotification__PlanType = Schema.Literals([
"free",
"go",
"plus",
"pro",
"prolite",
"team",
"self_serve_business_prolite",
"self_serve_business_usage_based",
"business",
"ent26",
"enterprise_cbp_automation",
"enterprise_cbp_usage_based",
"enterprise",
"edu",
"edu_plus",
"edu_pro",
"unknown",
]).annotate({ identifier: "V2AccountRateLimitsUpdatedNotification__PlanType" });
export type V2AccountRateLimitsUpdatedNotification__PlanType = string;
export const V2AccountRateLimitsUpdatedNotification__PlanType = Schema.String.annotate({
identifier: "V2AccountRateLimitsUpdatedNotification__PlanType",
});

export type V2AccountRateLimitsUpdatedNotification__RateLimitWindow = {
readonly resetsAt?: number | null;
Expand Down Expand Up @@ -4260,43 +4194,10 @@ export const V2AccountUpdatedNotification__AuthMode = Schema.Union(
identifier: "V2AccountUpdatedNotification__AuthMode",
});

export type V2AccountUpdatedNotification__PlanType =
| "free"
| "go"
| "plus"
| "pro"
| "prolite"
| "team"
| "self_serve_business_prolite"
| "self_serve_business_usage_based"
| "business"
| "ent26"
| "enterprise_cbp_automation"
| "enterprise_cbp_usage_based"
| "enterprise"
| "edu"
| "edu_plus"
| "edu_pro"
| "unknown";
export const V2AccountUpdatedNotification__PlanType = Schema.Literals([
"free",
"go",
"plus",
"pro",
"prolite",
"team",
"self_serve_business_prolite",
"self_serve_business_usage_based",
"business",
"ent26",
"enterprise_cbp_automation",
"enterprise_cbp_usage_based",
"enterprise",
"edu",
"edu_plus",
"edu_pro",
"unknown",
]).annotate({ identifier: "V2AccountUpdatedNotification__PlanType" });
export type V2AccountUpdatedNotification__PlanType = string;
export const V2AccountUpdatedNotification__PlanType = Schema.String.annotate({
identifier: "V2AccountUpdatedNotification__PlanType",
});

export type V2AppListUpdatedNotification__AppReview = { readonly status: string };
export const V2AppListUpdatedNotification__AppReview = Schema.Struct({
Expand Down Expand Up @@ -5484,43 +5385,10 @@ export const V2GetAccountRateLimitsResponse__SpendControlLimitSnapshot = Schema.
used: Schema.String,
}).annotate({ identifier: "V2GetAccountRateLimitsResponse__SpendControlLimitSnapshot" });

export type V2GetAccountRateLimitsResponse__PlanType =
| "free"
| "go"
| "plus"
| "pro"
| "prolite"
| "team"
| "self_serve_business_prolite"
| "self_serve_business_usage_based"
| "business"
| "ent26"
| "enterprise_cbp_automation"
| "enterprise_cbp_usage_based"
| "enterprise"
| "edu"
| "edu_plus"
| "edu_pro"
| "unknown";
export const V2GetAccountRateLimitsResponse__PlanType = Schema.Literals([
"free",
"go",
"plus",
"pro",
"prolite",
"team",
"self_serve_business_prolite",
"self_serve_business_usage_based",
"business",
"ent26",
"enterprise_cbp_automation",
"enterprise_cbp_usage_based",
"enterprise",
"edu",
"edu_plus",
"edu_pro",
"unknown",
]).annotate({ identifier: "V2GetAccountRateLimitsResponse__PlanType" });
export type V2GetAccountRateLimitsResponse__PlanType = string;
export const V2GetAccountRateLimitsResponse__PlanType = Schema.String.annotate({
identifier: "V2GetAccountRateLimitsResponse__PlanType",
});

export type V2GetAccountRateLimitsResponse__RateLimitWindow = {
readonly resetsAt?: number | null;
Expand Down Expand Up @@ -5563,43 +5431,10 @@ export const V2GetAccountRateLimitsResponse__RateLimitReachedType = Schema.Liter
"workspace_member_usage_limit_reached",
]).annotate({ identifier: "V2GetAccountRateLimitsResponse__RateLimitReachedType" });

export type V2GetAccountResponse__PlanType =
| "free"
| "go"
| "plus"
| "pro"
| "prolite"
| "team"
| "self_serve_business_prolite"
| "self_serve_business_usage_based"
| "business"
| "ent26"
| "enterprise_cbp_automation"
| "enterprise_cbp_usage_based"
| "enterprise"
| "edu"
| "edu_plus"
| "edu_pro"
| "unknown";
export const V2GetAccountResponse__PlanType = Schema.Literals([
"free",
"go",
"plus",
"pro",
"prolite",
"team",
"self_serve_business_prolite",
"self_serve_business_usage_based",
"business",
"ent26",
"enterprise_cbp_automation",
"enterprise_cbp_usage_based",
"enterprise",
"edu",
"edu_plus",
"edu_pro",
"unknown",
]).annotate({ identifier: "V2GetAccountResponse__PlanType" });
export type V2GetAccountResponse__PlanType = string;
export const V2GetAccountResponse__PlanType = Schema.String.annotate({
identifier: "V2GetAccountResponse__PlanType",
});

export type V2GetAccountResponse__AccountRoutingOverride = "NO_CONSTRAINT" | "us" | "us_cr";
export const V2GetAccountResponse__AccountRoutingOverride = Schema.Literals([
Expand Down
4 changes: 3 additions & 1 deletion packages/effect-codex-app-server/src/schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,15 @@ it("accepts Codex misalignment policy errors for thread responses", () => {
);
});

it("accepts Codex 0.150 account plan values", () => {
it("accepts account plan slugs newer than the pinned protocol", () => {
const planTypes = [
"self_serve_business_prolite",
"ent26",
"enterprise_cbp_automation",
"edu_plus",
"edu_pro",
"promax",
"some_future_plan",
];

for (const planType of planTypes) {
Expand Down
Loading