Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions apps/web/src/browser/HostedBrowserWebview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,23 +159,36 @@ export function HostedBrowserWebview(props: {
// A click inside the guest only reaches this document as a webview focus
// event, so open menus and popovers never see the outside press that
// would dismiss them. Replay it as a pointerdown on the webview itself.
const dismissHostPopups = () => {
//
// Hidden guests cannot be clicked by a person, so their focus comes from
// agent automation (CDP mouse input focuses the target guest). Hand focus
// back to whatever the user was typing into instead of swallowing keys.
const onWebviewFocus = (event: FocusEvent) => {
const surface = useBrowserSurfaceStore.getState().byTabId[runtimeTabId];
if (!surface?.visible || !surface.rect) {
if (event.relatedTarget instanceof HTMLElement) {
event.relatedTarget.focus({ preventScroll: true });
} else {
webview.blur();
}
return;
}
webview.dispatchEvent(
new PointerEvent("pointerdown", { bubbles: true, pointerType: "mouse" }),
);
};
Comment thread
coderabbitai[bot] marked this conversation as resolved.
webview.addEventListener("did-attach", register);
webview.addEventListener("dom-ready", register);
webview.addEventListener("render-process-gone", recoverGuest);
webview.addEventListener("focus", dismissHostPopups);
webview.addEventListener("focus", onWebviewFocus);
register();
return () => {
disposed = true;
if (recoveryTimeout !== null) clearTimeout(recoveryTimeout);
webview.removeEventListener("did-attach", register);
webview.removeEventListener("dom-ready", register);
webview.removeEventListener("render-process-gone", recoverGuest);
webview.removeEventListener("focus", dismissHostPopups);
webview.removeEventListener("focus", onWebviewFocus);
};
}, [clientSettingsHydrated, config, initialSrc, runtimeTabId, webviewGeneration]);

Expand Down
Loading