Skip to content

fix(web): thread panel lists the project's saved scripts - #14350

Merged
juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
t3code/thread-panel-project-scripts
Sep 30, 2026
Merged

juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
t3code/thread-panel-project-scripts

Conversation

@gabrielelpidio

@gabrielelpidio gabrielelpidio commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Scripts added from the thread details panel (the workspace popover in the title bar) saved, but never showed up in it. The panel only ever offered "Add project script".

The panel was handed activeProject?.scripts, the project aggregate's own list, which is empty now that project actions live in projectSettingsOverrides. The save path already built on the resolved list, so each add was written to settings and then read back as empty. The panel now gets the same resolved activeProjectScripts the rest of ChatView uses (resolveProjectScripts), still undefined when there is no project so the row stays hidden.

Regressed in 28abdc5 ("Map thread panel into title bar and sidebar"); main is unaffected.

Verified with tsc --noEmit for apps/web and lint on the file. Checked in the web client against a copy of real data: the panel now lists the t3chat project's saved script, and a script added from the panel appears in its menu immediately.

🤖 Generated with Claude Code

The thread details panel read the project aggregate's `scripts`, which
stay empty now that actions live in `projectSettingsOverrides`. Scripts
added from the panel saved correctly but never appeared. Pass the
resolved list the chat header already uses.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 30, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 880fb4e

Macroscope's review found this PR approvable — This is a one-line, self-contained fix that wires the thread panel to the same resolved project-script list already used elsewhere, while preserving the no-project behavior. It introduces no schema, deployment, security, billing, authentication, default, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 880fb4e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge merged commit 8ca8bd7 into t3code/codex-turn-mapping Sep 30, 2026
24 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/thread-panel-project-scripts branch September 30, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants