Repository navigation
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes production chat-canvas geometry across panel visibility, viewport widths, card placement, and preview resizing, with several components now coordinating through new layout rules. The behavior is well-tested and scoped to the web UI, but the default layout changes and cross-component runtime impact merit human review. You can add or adjust custom eligibility rules. Learn more. |
|
Note This comment is posted by Julius' dot Closing for missing before/after and interaction evidence. The PR supplies one after image and reports 43 focused layout tests, but no matching before image or recording showing the chat staying fixed as a preview opens, closes and resizes. Those transitions are central to the proposed fix. Please add the baseline comparison and a short integrated-client recording at the reported laptop size, with the narrow-layout check and any synthetic-preview limitations clearly identified, then request reconsideration. The workspace-card visibility report and focused tests remain useful. |
The new orchestrator could hide the workspace card at the default 14-inch MacBook Pro resolution. Opening a browser preview could move the chat.
Keep the workspace card at its usual 312 px width in a stable lane on the right. Balance the chat margins to place it as close to the center as the available space allows, while keeping the conversation readable. Very narrow layouts hide the card. Opening, closing, and resizing a preview keep the chat in place; large previews fit around the composer and essential workspace controls.
Verified with 43 focused layout tests, web typecheck, targeted lint and formatting, and the real web client at 1512×948. At 390×844, the card is hidden with no space above the chat or horizontal overflow. Live canvas checks used synthetic preview reports because the native desktop browser surface is unavailable in the web preview.
After image from an isolated local conversation fixture:
Updated against V2 main. The original layout changes are retained. ChatCanvas now uses the saved inline-card setting for its chat lane, so folding the card into a closed popover cannot move the conversation.
Current verification: 152 focused tests, web typecheck, targeted lint and formatting passed. Real web checks at 1512×948 kept the composer and timeline rectangles unchanged through preview opening, closing, reopening, and resizing to 320 px, 480 px, and a requested 900 px (fitted to 845 px). The workspace card stayed 312 px wide and folded as needed. At 390×844, the inline card was hidden and the document width was 390 px. Matching before/after images, a narrow-layout image, and a continuous interaction video were captured. The real web components used synthetic preview state; native desktop page content was not exercised.
Built with GPT-6.1-Sol in the Codex harness.