Skip to content

fix(web): keep thread actions in place on hover - #14974

Closed
RakshithBhat03 wants to merge 1 commit into
pingdotgg:mainfrom
RakshithBhat03:fix/subagent-action-hover-layout
Closed

RakshithBhat03 wants to merge 1 commit into
pingdotgg:mainfrom
RakshithBhat03:fix/subagent-action-hover-layout

Conversation

@RakshithBhat03

@RakshithBhat03 RakshithBhat03 commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Hovering a thread creation or subagent completion row reveals its timestamp and shifts the "Open chat" or "Open subagent" button under the pointer. The timestamp now appears before the trailing actions, keeping the buttons and disclosure chevron in place on hover and keyboard focus. This is a small layout correction to existing controls.

Tests: 213 focused timeline tests, web typecheck, targeted lint with warnings in unchanged code, and a real-client before/after hover check using a delegated subagent.

Before After
Button shifts on hover Button stays in place on hover

Before:

subagent-hover-before.mp4

After:

subagent-hover-after.mp4

Built by GPT 6.1 Sol in T3 Code through the Codex harness.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 3, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 39fa4fa

Macroscope's review found this PR approvable — This is a focused one-file UI correction that reorders an existing timestamp so hover/focus visibility no longer shifts thread-action click targets. It introduces no API, configuration, security, billing, or deployment changes.

No code changes detected at 8127f1a. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@RakshithBhat03
RakshithBhat03 force-pushed the fix/subagent-action-hover-layout branch from 39fa4fa to 8127f1a Compare October 3, 2026 02:56
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 3, 2026 — with ChatGPT Codex Connector
@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 11cb3734-4d33-43a9-a613-ce09876e811c
📥 Commits

Reviewing files that changed from the base of the PR and between bb79977 and 8127f1a.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/MessagesTimeline.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The work-entry timestamp moved to the start of the trailing controls, before thread actions and failure indicators. Its placement comment now describes this order.

Changes

Work-entry timestamp order

Layer / File(s) Summary
Position timestamp before trailing controls
apps/web/src/components/chat/MessagesTimeline.tsx
The work-entry timestamp now appears before thread actions and failure indicators. The placement comment describes the timestamp as preceding trailing actions and disclosure controls.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 8127f

The timestamp now appears before the trailing controls, keeping them in place as it becomes visible. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the problem, the layout change, and the verification performed. It includes before-and-after screenshots, but it does not provide the required scope and approval details or ex… Add a link to the triaged issue or maintainer approval. If no prior issue or discussion was needed, explain why this is a focused fix for an obvious bug.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: keeping thread actions in place when users hover.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the layout change, and the verification performed. It includes before-and-after screenshots, but it does not provide the required scope and approval details or explain why this focused fix qualifies without prior approval.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@maria-rcks

Copy link
Copy Markdown
Collaborator

superseded by #15281

@maria-rcks maria-rcks closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants