Repository navigation
fix(web): center the icon in thread details panel icon chips - #15398
abderbejaoui wants to merge 1 commit into
Conversation
Panel controls lay out with `inline-flex items-center` and never reach the `Button` base class that adds `justify-center`, so the 14px icon in a 24px `part="icon"` chip sat at the left edge and the hover fill ran past it on the right. Center the chip's content in its shared class, which also covers the Automations manage, edit and run buttons.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR makes a narrowly scoped cosmetic fix to center icons in existing thread-details controls. It changes only styling in one web component, with no API, data, default, deployment, or static-analysis implications. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe thread details panel icon action class now includes ChangesThread details action button alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change centers the relevant panel action icons without affecting the standard Button path. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Note Grok responding on behalf of Julius. Closing as superseded by #15669, which just merged the same fix (centering the icon in the shared thread details icon button style in |
Problem
The Lineage "More thread actions" button in the thread details panel shows its hover background offset from the three-dot icon: about 3px of fill before the dots and about 12px after. The button is a
ThreadDetailsControlwithpart="icon". In the panel path,sizeandvariantnever reachButton, whose base class includesjustify-center; instead the control usesTHREAD_DETAILS_PANEL_ICON_ACTION_CLASS(size-6,p-0) on top of the shared panel control classes, which areinline-flex items-centerwithoutjustify-center. Thesize-3.5icon therefore stays at the start of the 24px box while the hover fill covers the whole box. The Automations manage, edit and run buttons use the same class and are offset the same way.Reported in #15306 with a screenshot; confirmed by triage on
main, which traced the class path and named centering the content inTHREAD_DETAILS_PANEL_ICON_ACTION_CLASSas the first fix option.Change
THREAD_DETAILS_PANEL_ICON_ACTION_CLASSgainsjustify-center, with a one-line comment on why the chip centers its own content. Nothing else changes: the panel path still owns its density and ignoressizeandvariant, and the other panel part classes are untouched.Scope and approval
Bug fix for the triaged issue #15306 (cosmetic). Triage confirmed it on current
mainand listed this change as a fix option. One underlying problem; the web-only change touches one style constant.Verification
items-center; addingjustify-centerplaces the 14px icon at 5px from each edge instead of at the left edge, so the hover fill is symmetric around it. The same constant styles the three Automations icon buttons, so they center as well.pnpm run typecheckinapps/web: 0 errors.vp test run --project unitonThreadRelationshipsControl.test.tsx,ThreadRelationshipsControl.agents.test.tsxandThreadDetailsPanel.test.tsx: 10 passed.vp fmt --check: clean.vp lint --report-unused-disable-directives: exit 0.Claude Fable 5.1 (claude-fable-5-1) in Claude Code did the implementation; the account holder reviewed and owns the commit.