fix(vcs): passive sidebar rows stop retaining remote pollers - #15666
maria-rcks wants to merge 1 commit into
Conversation
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 16 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (11)
Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes existing sidebar subscriptions to suppress remote VCS polling and propagates that decision through the RPC contract, server poller lifecycle, and background-demand reporting. The behavior is well tested and backward-compatible for other callers, but it changes effective product behavior and gates non-trivial production work, warranting human review. You can add or adjust custom eligibility rules. Learn more. |
passive regular/search sidebar rows and palette badges now observe local status without retaining remote pollers. cached remote badges and updates from active vcs consumers are preserved; active web, desktop, and mobile controls retain their existing refresh behavior.
preserves cheruvian's subscription boundary from #6016 in a focused change. cache eviction remains owned by #15301. refs #5722 because selected-thread controls and ref discovery are unchanged.
verified on
644c82c6a0c823b9c180a8d2355b0364cfc48ec5: 249 focused tests, scoped lint/format, and contracts/client-runtime/server/web/mobile typechecks on blacksmith. real git repositories plus a worktree and bare origin verify passive local updates, active remote refresh, and release while passive observers remain. browser/provider/client runtime, media, native client coverage, and two final reviews remain pending with the parent.model:
gpt-6.1-sol; harness: codex.