Skip to content

fix(vcs): passive sidebar rows stop retaining remote pollers - #15666

Open
maria-rcks wants to merge 1 commit into
pingdotgg:mainfrom
maria-rcks:fix/round2-next-5722
Open

maria-rcks wants to merge 1 commit into
pingdotgg:mainfrom
maria-rcks:fix/round2-next-5722

Conversation

@maria-rcks

Copy link
Copy Markdown
Collaborator

passive regular/search sidebar rows and palette badges now observe local status without retaining remote pollers. cached remote badges and updates from active vcs consumers are preserved; active web, desktop, and mobile controls retain their existing refresh behavior.

preserves cheruvian's subscription boundary from #6016 in a focused change. cache eviction remains owned by #15301. refs #5722 because selected-thread controls and ref discovery are unchanged.

verified on 644c82c6a0c823b9c180a8d2355b0364cfc48ec5: 249 focused tests, scoped lint/format, and contracts/client-runtime/server/web/mobile typechecks on blacksmith. real git repositories plus a worktree and bare origin verify passive local updates, active remote refresh, and release while passive observers remain. browser/provider/client runtime, media, native client coverage, and two final reviews remain pending with the parent.

model: gpt-6.1-sol; harness: codex.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fdc0147c-288e-4cc4-8e33-e350f7ca4661
📥 Commits

Reviewing files that changed from the base of the PR and between 4ee6bfd and 644c82c.

📒 Files selected for processing (11)
  • apps/mobile/src/connection/background-activity-scopes.ts
  • apps/mobile/src/connection/background-activity.test.ts
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/vcs/VcsStatusBroadcaster.test.ts
  • apps/server/src/vcs/VcsStatusBroadcaster.ts
  • apps/web/src/components/Sidebar.tsx
  • apps/web/src/components/ThreadStatusIndicators.tsx
  • apps/web/src/lib/backgroundActivityReporter.test.ts
  • apps/web/src/lib/backgroundActivityReporter.ts
  • packages/contracts/src/git.ts
  • packages/contracts/src/rpc.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 4, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes existing sidebar subscriptions to suppress remote VCS polling and propagates that decision through the RPC contract, server poller lifecycle, and background-demand reporting. The behavior is well tested and backward-compatible for other callers, but it changes effective product behavior and gates non-trivial production work, warranting human review.

You can add or adjust custom eligibility rules. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant