Skip to content

fix(web): round the PR checks hover corners - #16020

Closed
kcybe wants to merge 2 commits into
pingdotgg:mainfrom
kcybe:fix/pr-checks-hover-corners
Closed

kcybe wants to merge 2 commits into
pingdotgg:mainfrom
kcybe:fix/pr-checks-hover-corners

Conversation

@kcybe

@kcybe kcybe commented Oct 5, 2026 •

Copy link
Copy Markdown

Status

Superseded by upstream PR #16746. It replaced the PR checks row, removed the chevron, and uses a rounded metadata control. The original square-corner hover no longer exists in the current implementation.

Merged the latest main into this branch and resolved the conflict by keeping the replacement implementation and removing the obsolete split-checks style. The branch now has no remaining code diff against the main commit it incorporates (cd41c4ada0).

Verification after conflict resolution

  • Web package typecheck passed: vp run --filter @t3tools/web typecheck.
  • Focused lint passed for threadDetailsPanelStyles.ts, ThreadDetailsControl.tsx, and ThreadDetailsPrRow.tsx.
  • Existing ThreadDetailsPrRows.test.tsx and ThreadDetailsPanel.test.tsx: 2 files, 4 tests passed.
  • Formatting check passed for the resolved styles file. No unmerged entries remain, and the resolved tree matches upstream main.

Original visual evidence

These fresh local screenshots demonstrate the original bug and the original one-line fix, before the upstream redesign. They are retained as historical evidence, not screenshots of the current layout. None is reused from the user's report or committed to the repository.

Theme Before After
Dark Before: square PR checks hover corners After: rounded PR checks hover corners
Light Before in light theme After in light theme

Agent: GPT-6.1-Sol, Codex harness in T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 5, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c375979

Macroscope's review found this PR approvable — This is a focused one-line CSS correction that rounds only the outer edge of the existing PR checks control when it ends the row, without changing behavior, data flow, or integrations. The affected runtime surface is limited to the web UI's visual styling.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1bd307ec-594e-452f-b971-cfdb53b21985
📥 Commits

Reviewing files that changed from the base of the PR and between 7812230 and c375979.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/threadDetailsPanelStyles.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The split-check class string now adds trailing-end rounding to the last check button.

Changes

Split-check styling

Layer / File(s) Summary
Last control corner rounding
apps/web/src/components/chat/threadDetailsPanelStyles.ts
THREAD_DETAILS_PANEL_SPLIT_CHECKS_CLASS adds last:rounded-e-lg to round the trailing end of the last check button.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: rakshithbhat03

Merge Risk: ⚪ Minimal · up to c3759

This change only rounds the trailing end of the last checks control. No actionable merge-blocking risk is indicated by the supplied context.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains that the original change was superseded and gives detailed verification results. However, it does not provide the template’s Problem, Change, or Scope and approval sections, o… Add the Problem, Change, and Scope and approval sections. Explain the original bug and fix, provide the issue or maintainer approval, or explain why this small fix qualifies for an exemption. Clarify the PR’s purpose now that it has no code…
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the original change: rounding the PR checks hover corners.
Full details: Description check

Explanation

The description explains that the original change was superseded and gives detailed verification results. However, it does not provide the template’s Problem, Change, or Scope and approval sections, or explain why the original fix qualifies for an exemption.

Resolution

Add the Problem, Change, and Scope and approval sections. Explain the original bug and fix, provide the issue or maintainer approval, or explain why this small fix qualifies for an exemption. Clarify the PR’s purpose now that it has no code diff against main.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kcybe kcybe closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant