fix(desktop): capture background browser tabs without stalling

apps/desktop/src/ipc/DesktopIpcHandlers.ts

@@ -85,6 +85,7 @@ export const installDesktopIpcHandlers = Effect.fn("desktop.ipc.installHandlers"
   const ipc = yield* DesktopIpc.DesktopIpc;
   yield* installNotificationBadge();
   yield* PreviewIpc.installPreviewEventForwarding();
+  yield* ipc.handle(PreviewIpc.acknowledgeCapture);
 
   yield* ipc.handle(AppActivationIpc.setReady);
   yield* ipc.handle(AppActivationIpc.complete);

apps/desktop/src/ipc/channels.ts

@@ -109,6 +109,8 @@ export const PREVIEW_RECORDING_SAVE_CHANNEL = "desktop:preview-recording-save";
 export const PREVIEW_RECORDING_FRAME_CHANNEL = "desktop:preview-recording-frame";
 export const PREVIEW_STATE_CHANGE_CHANNEL = "desktop:preview-state-change";
 export const PREVIEW_POINTER_EVENT_CHANNEL = "desktop:preview-pointer-event";
+export const PREVIEW_CAPTURE_REQUEST_CHANNEL = "desktop:preview-capture-request";
+export const PREVIEW_CAPTURE_READY_CHANNEL = "desktop:preview-capture-ready";
 export const PREVIEW_OPEN_LINK_CHANNEL = "desktop:preview-open-link";
 
 export const MAC_PERMISSION_HELPER_CHANNEL = "desktop:mac-permission-helper";

apps/desktop/src/ipc/methods/preview.ts

@@ -27,6 +27,7 @@ import {
 import * as Effect from "effect/Effect";
 import * as Schema from "effect/Schema";
 import * as Option from "effect/Option";
+import * as Stream from "effect/Stream";
 import * as NodeURL from "node:url";
 
 import * as ElectronWindow from "../../electron/ElectronWindow.ts";
@@ -36,12 +37,20 @@ import * as DesktopClientSettings from "../../settings/DesktopClientSettings.ts"
 import { PREVIEW_WEBVIEW_PREFERENCES } from "../../preview/WebviewPreferences.ts";
 import * as IpcChannels from "../channels.ts";
 import * as DesktopIpc from "../DesktopIpc.ts";
+import * as DesktopBrowserHost from "../../preview/DesktopBrowserHost.ts";
 
 export const installPreviewEventForwarding = Effect.fn(
   "desktop.ipc.preview.installEventForwarding",
 )(function* () {
   const electronWindow = yield* ElectronWindow.ElectronWindow;
   const manager = yield* PreviewManager.PreviewManager;
+  const browserHost = yield* DesktopBrowserHost.DesktopBrowserHost;
+  yield* browserHost.captureRequests.pipe(
+    Stream.runForEach((event) =>
+      electronWindow.sendAll(IpcChannels.PREVIEW_CAPTURE_REQUEST_CHANNEL, event),
+    ),
+    Effect.forkScoped,
+  );
   yield* manager.subscribeStateChanges((tabId, state) =>
     electronWindow.sendAll(IpcChannels.PREVIEW_STATE_CHANGE_CHANNEL, tabId, state),
   );
@@ -59,6 +68,18 @@ export const installPreviewEventForwarding = Effect.fn(
   );
 });
 
+export const acknowledgeCapture = DesktopIpc.makeIpcMethod({
+  channel: IpcChannels.PREVIEW_CAPTURE_READY_CHANNEL,
+  payload: Schema.String,
+  result: Schema.Void,
+  handler: Effect.fn("desktop.ipc.preview.acknowledgeCapture")(function* (requestId, event) {
+    const main = yield* (yield* ElectronWindow.ElectronWindow).main;
+    if (!event || Option.isNone(main) || main.value.webContents.id !== event.sender.id) return;
+    const host = yield* DesktopBrowserHost.DesktopBrowserHost;
+    host.acknowledgeCapture(requestId);
+  }),
+});
+
 export const setForwardedShortcuts = DesktopIpc.makeIpcMethod({
   channel: IpcChannels.PREVIEW_SET_FORWARDED_SHORTCUTS_CHANNEL,
   payload: Schema.Array(PreviewForwardedShortcut).check(Schema.isMaxLength(MAX_KEYBINDINGS_COUNT)),

apps/desktop/src/preload.ts

@@ -2,6 +2,7 @@ import type {
   DesktopBridge,
   DesktopPreviewOpenLinkEvent,
   DesktopPreviewPointerEvent,
+  DesktopPreviewCaptureRequest,
   DesktopPreviewRecordingInputEvent,
   DesktopPreviewRecordingFrame,
   DesktopPreviewTabState,
@@ -417,6 +418,17 @@ contextBridge.exposeInMainWorld("desktopBridge", {
       return () =>
         ipcRenderer.removeListener(IpcChannels.PREVIEW_POINTER_EVENT_CHANNEL, wrappedListener);
     },
+    acknowledgeCapture: (requestId) =>
+      ipcRenderer.invoke(IpcChannels.PREVIEW_CAPTURE_READY_CHANNEL, requestId),
+    onCaptureRequest: (listener) => {
+      const wrappedListener = (
+        _event: Electron.IpcRendererEvent,
+        request: DesktopPreviewCaptureRequest,
+      ) => listener(request);
+      ipcRenderer.on(IpcChannels.PREVIEW_CAPTURE_REQUEST_CHANNEL, wrappedListener);
+      return () =>
+        ipcRenderer.removeListener(IpcChannels.PREVIEW_CAPTURE_REQUEST_CHANNEL, wrappedListener);
+    },
     onOpenLink: (listener) => {
       const wrappedListener = (_event: Electron.IpcRendererEvent, linkEvent: unknown) => {
         if (typeof linkEvent !== "object" || linkEvent === null) return;