Repository navigation
fix(web): omit underlines on markdown image links - #17728
Merged
Yash-Singh1 merged 4 commits intoOct 10, 2026
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained web rendering fix that suppresses the dotted hover/focus decoration only for image-only markdown links while preserving existing text-link behavior and navigation. Its runtime impact is limited to presentation, with no new workflow, schema, configuration, or sensitive-area changes. You can add or adjust custom eligibility rules. Learn more. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Oct 10, 2026
## What's Changed * fix(web): align compact button touch targets by @Yash-Singh1 in pingdotgg/t3code#17748 * fix(server): t3_thread_launch refuses a new worktree whose base ref has no commit by @tris203 in pingdotgg/t3code#17791 * fix(web): omit underlines on markdown image links by @Saikrishna1876 in pingdotgg/t3code#17728 * fix(server): restore auto resume for wrapped Claude gateway rate limits by @tzachbon in pingdotgg/t3code#17778 * fix(opencode): name OpenCode 2 sessions after their thread by @nkoynov in pingdotgg/t3code#17414 * fix(web): find update settings from the command palette by @sergical in pingdotgg/t3code#17396 * fix(provider-opencode): tell OpenCode Zen and Go models apart by @mr-karan in pingdotgg/t3code#17424 * fix(server): a pull that fast-forwards no longer fails on large Git output by @ScottN-PV in pingdotgg/t3code#17376 * fix(web): cancel question auto-advance after navigation by @maxwellyoung in pingdotgg/t3code#17364 * fix(server): a bare repository name resolves to the signed-in account again by @ScottN-PV in pingdotgg/t3code#17379 * fix(web): a maximized right panel stays maximized when you return to its thread by @jamesvillarrubia in pingdotgg/t3code#17327 * fix(mobile): allow starting a task with only an image by @Claudesaul in pingdotgg/t3code#17409 * fix(server): PR watch no longer reports passed while a second run of a check is still going by @ScottN-PV in pingdotgg/t3code#17344 * fix(server): say why a thread can't be settled by @DylanTX in pingdotgg/t3code#17258 * fix(server): prevent busy terminals from starving history persistence by @StiensWout in pingdotgg/t3code#17181 * feat(server): use macOS .icns app icons as project icons by @psv2522 in pingdotgg/t3code#17149 * fix(mobile): usage reset icon lines up with its row by @Aforno in pingdotgg/t3code#17175 * fix(web): paths pasted after @ keep their underscores by @derektrimm in pingdotgg/t3code#16619 * fix(server): settle every OpenCode subagent call one report answers by @nkoynov in pingdotgg/t3code#17134 * perf(web): switching project keeps Diagnostics and Providers mounted by @flamboh in pingdotgg/t3code#17122 * perf(web): Open Source Licenses downloads its manifest once per session by @flamboh in pingdotgg/t3code#17119 * fix(server): restore OpenCode adapter test typecheck by @Yash-Singh1 in pingdotgg/t3code#17810 * fix(server): Claude subagents show the reasoning effort they run at by @RakshithBhat03 in pingdotgg/t3code#17496 ## New Contributors * @tzachbon made their first contribution in pingdotgg/t3code#17778 * @sergical made their first contribution in pingdotgg/t3code#17396 * @mr-karan made their first contribution in pingdotgg/t3code#17424 * @Claudesaul made their first contribution in pingdotgg/t3code#17409 * @DylanTX made their first contribution in pingdotgg/t3code#17258 * @psv2522 made their first contribution in pingdotgg/t3code#17149 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2922...v0.0.46-nightly.20261010.2935 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2935
github-actions Bot
added a commit
to davidvanderklay/t3code-flake
that referenced
this pull request
Oct 10, 2026
## What's Changed * fix(web): align compact button touch targets by @Yash-Singh1 in pingdotgg/t3code#17748 * fix(server): t3_thread_launch refuses a new worktree whose base ref has no commit by @tris203 in pingdotgg/t3code#17791 * fix(web): omit underlines on markdown image links by @Saikrishna1876 in pingdotgg/t3code#17728 * fix(server): restore auto resume for wrapped Claude gateway rate limits by @tzachbon in pingdotgg/t3code#17778 * fix(opencode): name OpenCode 2 sessions after their thread by @nkoynov in pingdotgg/t3code#17414 * fix(web): find update settings from the command palette by @sergical in pingdotgg/t3code#17396 * fix(provider-opencode): tell OpenCode Zen and Go models apart by @mr-karan in pingdotgg/t3code#17424 * fix(server): a pull that fast-forwards no longer fails on large Git output by @ScottN-PV in pingdotgg/t3code#17376 * fix(web): cancel question auto-advance after navigation by @maxwellyoung in pingdotgg/t3code#17364 * fix(server): a bare repository name resolves to the signed-in account again by @ScottN-PV in pingdotgg/t3code#17379 * fix(web): a maximized right panel stays maximized when you return to its thread by @jamesvillarrubia in pingdotgg/t3code#17327 * fix(mobile): allow starting a task with only an image by @Claudesaul in pingdotgg/t3code#17409 * fix(server): PR watch no longer reports passed while a second run of a check is still going by @ScottN-PV in pingdotgg/t3code#17344 * fix(server): say why a thread can't be settled by @DylanTX in pingdotgg/t3code#17258 * fix(server): prevent busy terminals from starving history persistence by @StiensWout in pingdotgg/t3code#17181 * feat(server): use macOS .icns app icons as project icons by @psv2522 in pingdotgg/t3code#17149 * fix(mobile): usage reset icon lines up with its row by @Aforno in pingdotgg/t3code#17175 * fix(web): paths pasted after @ keep their underscores by @derektrimm in pingdotgg/t3code#16619 * fix(server): settle every OpenCode subagent call one report answers by @nkoynov in pingdotgg/t3code#17134 * perf(web): switching project keeps Diagnostics and Providers mounted by @flamboh in pingdotgg/t3code#17122 * perf(web): Open Source Licenses downloads its manifest once per session by @flamboh in pingdotgg/t3code#17119 * fix(server): restore OpenCode adapter test typecheck by @Yash-Singh1 in pingdotgg/t3code#17810 * fix(server): Claude subagents show the reasoning effort they run at by @RakshithBhat03 in pingdotgg/t3code#17496 ## New Contributors * @tzachbon made their first contribution in pingdotgg/t3code#17778 * @sergical made their first contribution in pingdotgg/t3code#17396 * @mr-karan made their first contribution in pingdotgg/t3code#17424 * @Claudesaul made their first contribution in pingdotgg/t3code#17409 * @DylanTX made their first contribution in pingdotgg/t3code#17258 * @psv2522 made their first contribution in pingdotgg/t3code#17149 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2922...v0.0.46-nightly.20261010.2935 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hovering a markdown image link draws a dotted text underline beside the image. This leaves blue dots around CodeRabbit's "Review Change Stack" button in pull request comments.
Change
Reuse the renderer's existing text detection to mark image-only links, then exclude them from the dotted hover and focus underline. Text links, including links with both text and images, keep their underline. The shared markdown renderer covers web and desktop chat, file previews, and pull request bodies and comments. Native mobile does not use this CSS.
Scope and approval
This is a small, focused fix for an obvious rendering defect under the CONTRIBUTING.md exception. It corrects the text decoration applied to image buttons without adding settings or changing link navigation.
Verification
vp test run apps/web/src/components/ChatMarkdown.test.tsx apps/web/src/components/ChatMarkdown.assets.test.tsx: 82 tests passed.vp run --filter @t3tools/web typecheck: passed.background-imageisnone. Hovered the adjacent text link and confirmed the dottedradial-gradientunderline remains.personalprofile completed with zero findings. Greptile could not review because the upstream repository is not connected to that account.Before, from the original report in dark mode:
After, hovered button in the development markdown fixture in light mode:
Model: gpt-6.1-sol. Harness: Codex through T3 Code.