Repository navigation
Conversation
- Host port: `fetchRemoteRef` fetches any remote ref into a local branch, for hosts whose pull request refs are not branches. - Bitbucket Cloud: the pull request id normalizer and the change request mapper are exported, so a second Bitbucket host can share them. - Client definitions: a null `publishDescription` keeps a host out of the Publish picker. - Desktop: the bundled server trusts the OS certificate store, for hosts behind a corporate CA.
This was referenced Oct 11, 2026
Member
|
Note This comment is posted by Julius' dot This prepares a new Data Center integration and changes the desktop's default TLS trust. #10837 still awaits maintainer sign-off on that direction and scope. The prior-approval requirement applies to drafts too, so I'm closing this. Please obtain approval in that discussion and link it when requesting reconsideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-hosted Bitbucket (Data Center / Server) support, proposed in #10837, needs four small things outside its own package. This PR lands only those, so the next two PRs stay inside the new package. It is the bottom of a three-PR stack: repositories in #18241, pull requests in #18242.
Summary
Desktop users can't set environment for the bundled server, so a host behind an organization's own certificate authority fails TLS there.
NODE_USE_SYSTEM_CAadds the OS store to Node's bundled roots; it removes nothing.Evidence
No UI change: the publish picker lists the same hosts, since no host returns
nullyet.GitVcsDriverCore.test.ts:fetchRemoteReffetches a non-branch ref into a local branch.DesktopBackendConfiguration.test.ts: the backend child env carriesNODE_USE_SYSTEM_CA=1.Merge Danger
Door: two-way
Blast Radius: desktop TLS
The bundled server now also trusts certificates from the OS store. That widens trust to whatever the machine trusts, which is what a browser on the same machine already does.
🤖 Generated with Claude Code — Claude Opus 5.5 in T3 Code