Repository navigation
Conversation
github-actions
Bot
added
vouch:trusted
juliusmarminge
added
the
macroscope-review
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR not approvable — This PR changes the default Android workspace experience across navigation, pane sizing, surfaces, headers, thread history, and composer/keyboard interactions. The breadth of production behavior and removal of existing navigation chrome require human review. You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the problem, implementation, verification steps, and includes UI evidence. However, it does not provide the required Scope and approval section with a triaged issue or explici… | Add a Scope and approval section with the relevant triaged issue or discussion and explicit maintainer approval, or explain why this focused change qualifies for an exemption. Add Problem and Change headings to match the repository template… |
-
Check name Status Explanation Title check The title clearly summarizes the main Android changes: removing the rail, bottom bar, and rounded sheets to create a denser layout. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Description check
-
Explanation
The description explains the problem, implementation, verification steps, and includes UI evidence. However, it does not provide the required Scope and approval section with a triaged issue or explicit maintainer approval. The Problem and Change content is also not labeled with the template headings.
Resolution
Add a Scope and approval section with the relevant triaged issue or discussion and explicit maintainer approval, or explain why this focused change qualifies for an exemption. Add Problem and Change headings to match the repository template.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
860f55d to
9e5e520
Compare
Split view on Android loses the 80dp navigation rail. The sidebar header now holds the Chats/PRs switch, search, filter, settings, and New thread, so no buttons float over the thread list. While the thread composer has the soft keyboard in split view, the sidebar steps aside, the header drops to one line, the composer stays one row (with the model picker and turn timer), and the Working pill stops taking feed height. Folded phones keep the bottom bar and FABs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llapsing thread title - Content no longer sits in a rounded, inset sheet under the header. - The Chats/PRs switch replaces the brand on compact screens too, so the 80dp bottom navigation bar (and its native view) is gone. - The thread toolbar collapses while the feed is scrolled back into history and returns at the latest message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9e5e520 to
9d6fa01
Compare
t3dotgg
changed the title
github-actions
Bot
added
size:XXL
…list at a reading width Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I feel a bit responsible for the current state this is updating, so I feel like I should chime in here:
I agree this one was kinda bad, but it was rushed out to replace the buggy replacement that was in the original PR tab merge. I'm not in love with that cluttered of a header, and one consideration I had when adding the rails was the upcoming Home and Issues features likely being added to the navigation area. I don't really see how either would fit in that header.
I still think we should keep the standard Android FAB here for Create Thread. Filter, I'm already proposing move up to the header on Android.
This was just fun and to fit in more with all the rounded content in MD3.
Auto-hiding headers is a good idea. I'm all for it. I'll still open the PR for the rail updates I was planning. Feel free to consider it or close it. |
Ports the keyboard layout from pingdotgg#19424. While the thread composer has the soft keyboard in Android split view, the rail and sidebar step aside, the thread header drops to one line, and the composer stays one row that grows with its text, with the model picker and turn timer in the row. Closing the keyboard restores the sidebar. Co-authored-by: Theo Browne <me@t3.gg>
This branch has not been deployed
3 participants
On Android, and especially on foldables, the app wasted a lot of space:
With the keyboard open in split view, the chat feed got about two lines.
Navigation
Surfaces
Threads
iOS is unchanged.
Verification
Pixel Fold emulator (API 36), dark mode, showcase data, release preview build:
vp test runforlib/layout.test.ts(new sidebar-width case) and the navigation color tests. Mobile typecheck and lint on the changed files are clean.Notes
Reviewed with sol-loop: 5 rounds with GPT-6.1-Sol on high.
Created with Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code