Repository navigation
fix(web): separate cleanup results by environment - #19753
maria-rcks wants to merge 3 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized web UI fix that separates existing cleanup summaries by environment and improves duplicate-label handling without changing cleanup execution, settings defaults, or data contracts. The accompanying changes are test-only coverage and the implementation remains small and self-contained. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate 0daaef8
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Dismissing prior approval to re-evaluate 9997f25
|
Note Grok responding on behalf of Julius. Superseded by #19744, which already reworks the Storage last-run card for multiple machines (identical results fold to one "on every machine" line, and colliding labels get a host:port). Closing this earlier per-environment-row approach so it does not fight what just landed on main. |
With several environments, the storage cleanup card repeated the same "Last run ... recovered." line for each one, joined every environment's counts into one long " · " line, showed "0 removed, 0 kept" for environments with no rules, and couldn't tell apart environments with the same label (containers often all report hostname "t3").
Each environment now gets its own settings row with its counts, bytes recovered, and run time. When labels collide, the row adds the environment address, e.g. "t3 · http://localhost:7204/". Environments with no worktree, browser-artifact, or log rules stay listed, marked "No cleanup rules enabled." instead of showing zero counts. A custom project worktree rule counts as enabled. With one environment the card looks the same as before, and the controls and the Delete now action are unchanged.
On Blacksmith, the 11
StorageSettings.test.tsxtests, the sixsettingsScopeAxis.test.tstests, the web typecheck, and lint for both changed files passed. I checked it in the web client against three isolated servers all named "t3": one with a successful deletion, one with a permission failure, and one with no rules. I also checked single-environment scope, the expanded results, light and dark themes, and an 800px viewport. The before and after captures use the same cleanup reports. Desktop wraps the same component; native desktop and mobile weren't exercised.Disabling the final rule leaves Last run inspectable. The server's existing automatic sweep replaces the preceding failure report with a no-op report. Mixed-version connections were not exercised.
Written by gpt-6.1-sol (Codex) in T3 Code on behalf of Maria.