Skip to content

fix(mobile): Android OTAs no longer reach builds missing their native code #20174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivamhwp wants to merge 1 commit into from
Closed

fix(mobile): Android OTAs no longer reach builds missing their native code #20174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions patches/@expo__fingerprint@0.21.5.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
diff --git a/build/sourcer/Expo.js b/build/sourcer/Expo.js
index 785ec516921af68ea5922462a0177112e15c6bb1..6e9c848f4ff7ae1a849994a84c0c7a038aed70c8 100644
--- a/build/sourcer/Expo.js
+++ b/build/sourcer/Expo.js
@@ -368,6 +368,12 @@ async function getExpoAutolinkingAndroidSourcesAsync(projectRoot, options, expoA
}
if (module1.plugins) {
for (const plugin of module1.plugins){
+ // Maven-only Gradle plugins (expo-widgets) have no sourceDir. Their id, group and
+ // version are hashed through expoAutolinkingConfig:android below. Without this
+ // skip, path.relative throws and the catch drops every Expo module from the hash.
+ if (typeof plugin.sourceDir !== 'string') {
+ continue;
+ }
const filePath = (0, _Path.toPosixPath)(_path().default.relative(realProjectRoot, plugin.sourceDir));
plugin.sourceDir = filePath; // use relative path for the dir
debug(`Adding expo-modules-autolinking android dir - ${_chalk().default.dim(filePath)}`);
5 changes: 3 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ patchedDependencies:
# Android: a nested WebView hands a vertical drag to its scrolling parent at the page's edge.
react-native-webview@14.0.1: patches/react-native-webview@14.0.1.patch
"@expo/ui@58.0.18": patches/@expo__ui@58.0.18.patch
"@expo/fingerprint@0.21.5": patches/@expo__fingerprint@0.21.5.patch

peerDependencyRules:
allowAny:
Expand Down
Loading