Skip to content

perf(web): the sidebar update capsule compiles without manual memoization #20687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
+14 −21
Merged

perf(web): the sidebar update capsule compiles without manual memoization #20687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 14 additions & 21 deletions apps/web/src/components/sidebar/SidebarUpdateCapsule.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useAtomValue } from "@effect/atom-react";
import { Atom } from "effect/reactivity";
import { type ReactNode, useCallback, useMemo, useSyncExternalStore } from "react";
import { type ReactNode, useSyncExternalStore } from "react";

import { cn } from "~/lib/utils";
import { serverEnvironment } from "~/state/server";
Expand All @@ -24,31 +24,24 @@ import {

function useNow(intervalMs: number | null): number {
const step = intervalMs ?? 60_000;
const subscribe = useCallback(
(onChange: () => void) => {
if (intervalMs === null) return () => {};
const timer = setInterval(onChange, intervalMs);
return () => clearInterval(timer);
},
[intervalMs],
);
const subscribe = (onChange: () => void) => {
if (intervalMs === null) return () => {};
const timer = setInterval(onChange, intervalMs);
return () => clearInterval(timer);
};
return useSyncExternalStore(subscribe, () => Math.floor(Date.now() / step) * step);
}

function useUpdateRunMachineViews(run: UpdateEverythingRun): ReadonlyArray<UpdateRunMachineView> {
const viewsAtom = useMemo(
() =>
Atom.make((get) =>
run.machines.map((machine) => ({
machine,
status: resolveUpdateRunMachineStatus(
machine,
run.phase,
get(serverEnvironment.updateStateAtom(machine.environmentId)),
),
})),
const viewsAtom = Atom.make((get) =>
run.machines.map((machine) => ({
machine,
status: resolveUpdateRunMachineStatus(
machine,
run.phase,
get(serverEnvironment.updateStateAtom(machine.environmentId)),
),
[run],
})),
);
return useAtomValue(viewsAtom);
}
Expand Down
Loading