Skip to content

refactor(web): provider models keep their caching without "use memo" #20775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

refactor(web): provider models keep their caching without "use memo" #20775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions apps/web/src/components/settings/ProviderModelsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,6 @@ interface ProviderModelsSectionProps {
readonly onModelOrderChange: (next: ReadonlyArray<string>) => void;
}

/** CustomModelEditor keys its option list on this array. */
function useBuiltInModels(models: ReadonlyArray<ServerProviderModel>) {
"use memo";
return models.filter((model) => !model.isCustom);
}

export function ProviderModelsSection({
instanceId,
driverKind,
Expand Down Expand Up @@ -153,9 +147,6 @@ export function ProviderModelsSection({
const hiddenCount = displayModels.filter(
(model) => !model.isCustom && hiddenModelSet.has(model.slug),
).length;
const builtInModels = useBuiltInModels(models);
const allBuiltInModelsHidden =
builtInModels.length > 0 && builtInModels.every((model) => hiddenModelSet.has(model.slug));
const showFilter = models.length > FILTER_THRESHOLD;
const normalizedFilter = filter.trim().toLowerCase();
const isFiltering = showFilter && normalizedFilter.length > 0;
Expand All @@ -179,6 +170,12 @@ export function ProviderModelsSection({
row.scrollIntoView({ block: "nearest" });
});

// CustomModelEditor keys its option list on this array. Derived after the effect and
// checked against `hiddenModels` rather than the set built above it, so it stays cached.
const builtInModels = models.filter((model) => !model.isCustom);
const allBuiltInModelsHidden =
builtInModels.length > 0 && builtInModels.every((model) => hiddenModels.includes(model.slug));

const handleAdd = () => {
if (!canManageCustomModels || driverKind === "antigravity") return;
const normalized = normalizeCustomModelSlug(input);
Expand Down
Loading