Skip to content

test(web): ChatMarkdown thread find waits for highlights to settle #21121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 18, 2026
+8 −4
Merged

test(web): ChatMarkdown thread find waits for highlights to settle #21121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/web/src/components/ChatMarkdown.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,10 +830,14 @@ describe("ChatMarkdown thread find", () => {
),
);
await frame();
const ranges = [...CSS.highlights.values()].flatMap((value) => [...value]);
expect(ranges.map((range) => (range as Range).toString())).toEqual(
Array.from({ length: count }, () => query),
);
// Lazy blocks such as Mermaid can swap their source text after the first frame,
// emptying a range for a moment, so wait for the highlights to settle.
await vi.waitFor(() => {
const ranges = [...CSS.highlights.values()].flatMap((value) => [...value]);
expect(ranges.map((range) => (range as Range).toString())).toEqual(
Array.from({ length: count }, () => query),
);
});
const segments =
searchableMessageSegments(
{ role: user ? "user" : "assistant", text, streaming: false },
Expand Down
Loading