Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped web command-palette bug fix that keeps the existing “New thread in…” project rows current while metadata arrives. It adds targeted browser regression coverage without changing APIs, schemas, defaults, or deployment behavior. You can add or adjust custom eligibility rules. Learn more. |
Contributor
PixPMusic
force-pushed
the
fix/multi-host-project-picker-reconciliation
branch
from
October 21, 2026 19:21
a0f0b4a to
40dcff2
Compare
macroscopeapp
Bot
dismissed
their stale review
October 21, 2026 19:22
Dismissing prior approval to re-evaluate 40dcff2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening ⌘N during startup can show a row for each host checkout, or an extra “No project” row, even after project metadata and host configuration arrive. The composer uses the current projects; the open picker keeps the rows captured when its submenu was pushed. Reopening the picker makes it look fixed.
#22242 restored grouped selection but also removed the submenu’s live-row refresh branch.
Change
Give “New thread in…” its own submenu key at both entry points and render its current project choices while it stays open. Grouping, contextual host selection, and thread creation keep their existing behavior.
Scope and approval
Small follow-up to #22242 for an obvious stale-view bug. This changes the shared web/Electron picker only. Mobile has a separate selector; no server, provider, RPC, or contract changes are needed.
Verification
41967084e3,vp run check:changedpasses: formatting, targeted lint, knip, affected web/scripts typechecks, and 21 tests acrossCommandPalette.projects.browser.test.tsxandCommandPalette.logic.test.ts. The four picker regression cases were moved out of the focus-test file deleted upstream; the original production fix is unchanged.git diff --checkpass.t3/use-sanitized-demo-test-fixtures: open ⌘N, then deliver a project update through the existing command service so a second checkout resolves to the same repository. Baseline retains two T3 Code rows; this branch collapses them without reopening. Captures use two local checkouts on one isolated server; cross-host arrivals are covered by the browser regression fixtures. A packaged desktop cold start was not tested.Model: GPT-6.1 Sol | Harness: Codex in T3 Code