Repository navigation
Conversation
Two slop audits found code nothing reaches. This removes the parts that need no product decision: dead exports and files, code only its own tests keep alive, client checks on capability flags every protocol-2 server has always sent as true, legacy paths for peers that cannot connect, orphan fixtures, unused RPCs, deps and assets, and manual memos the React Compiler already handles in mobile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This is a repository-wide mixed cleanup that also changes production behavior across authentication, RPC contracts, mobile/web capability gating, desktop IPC, orchestration, and notification delivery. The size, cross-owner scope, and omitted diff content make the runtime impact too broad for automatic approval. You can add or adjust custom eligibility rules. Learn more. |
Another slop audit. A lot of this repo is code that nothing can reach: dead exports, code that only its own tests keep alive, client checks on capability flags that every protocol-2 server has always sent as
true, legacy paths for peers that can no longer connect, and fixtures that the October test purge (#22557) left behind.This PR deletes the parts that need no product decision. Users see no change. It removes about 20.5k lines net across 920 files, and 72 files are gone.
What goes
trueon all 119 protocol-2 releases, and 2 were nevertrue. Clients checked them about 190 times. The server still sends every flag, because older app-store mobile builds read them. Where a check also waited for the server config, an explicit config check stays. With the checks go the legacy "context as text" send path, single-link PR mode, the client-side command-context fallback, the full-snapshot fallback, and per-update thread continuation.ProjectionStore.layerMemory), the ACP event builders, the Grok background translator, the OpenCode CLI inventory, the sidebar PR snapshot code, and the old mobile connection store.ThreadLifecycleService, dead private layers, unreachable timeline branches, deadGitActionsControlmodes, props nobody passes, and exports that only their own file uses.acp-mock-agentflags no test sets, native regression fixtures whose test is gone, and a fixture kit for a closed issue.useMemo/useCallbackcalls in files the React Compiler already compiles. Each removal was checked against the compiled output, so the value still comes from the compiler cache with the same deps. 152 stay, because removing them would drop caching.Review tip: hide whitespace. Many tests only lost an indent level, and the memo removals move function bodies left. With whitespace hidden, the diff is +2,494 / -22,999.
Not in this PR (product calls or refactors): LegacySidebar, legacy Plan mode, OpenCode 1.x, the V1 importer and old data migrations, the 5 flags missing from early previews, the resource monitor, hand-run package scripts, and merging the logic that web and mobile both carry.
One finding for later:
vite.config.tsplans to ban memo hooks in mobile once the React Compiler allowlist is empty. The 152 memos kept here show that the ban would drop caching in real cases.Verification
vp run check:changedon the rebased branch: format, lint, knip, typecheck of 32 packages, and 4,912 of 4,913 tests pass. The one failure isAcpSessionRuntime.processTree. It fails the same way onmainon this machine, because the machine has no/usr/bin/node.Created with Claude Opus 5.5 in Claude Code, inside T3 Code. Claude Sonnet 5.5 and Claude Haiku 5.5 helped with the audit. GPT-6.1 Sol in Codex worked on the audit, several slices, and the review.
🤖 Generated with Claude Code