Skip to content

fix(web): keep completed assistant copy actions visible - #4107

Closed
maxwellyoung wants to merge 4 commits into
pingdotgg:mainfrom
maxwellyoung:codex/fix-assistant-copy-button-visibility
Closed

maxwellyoung wants to merge 4 commits into
pingdotgg:mainfrom
maxwellyoung:codex/fix-assistant-copy-button-visibility

Conversation

@maxwellyoung

@maxwellyoung maxwellyoung commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Completed assistant responses hide their copy action when the pointer leaves the row, including after selecting response text. Keep the shared assistant footer visible and remove its unused hover group and visibility toggle.

Fixes #4046.

Validation: 142 focused timeline tests pass. In the isolated local web client, selected response text and moved the pointer away: the footer disappears before the change and remains visible after it. Clicking Copy copies the complete response, including its list, rather than only the selected paragraph.

Web typechecking reports TS2554 in fileEditorVirtualization.test.ts:260. The same error occurs on unchanged main at eced382.

Before: selected response text, then moved the pointer outside the row.

Before: copy action hidden

After: the same selection and pointer movement leaves the copy action visible.

After: copy action visible

copy-footer-after.webm

Note

Keep completed assistant copy actions visible and harden desktop update state across re-checks

  • Preserves downloaded desktop update state through check-start, check-failure, update-available, and no-update transitions so a previously downloaded update stays actionable instead of being discarded or errored
  • Adds the Antigravity provider as a built-in driver with release-asset resolution, model catalog integration, client settings schema, and icon support across server, web, and mobile
  • Introduces exponential backoff for managed relay connector restarts (1s base, 60s cap, 30s stable-uptime window) to prevent crash loops
  • Migrates mobile and web UI components from JavaScript theme-color lookups to class-based Uniwind styling and appearance-provider-driven theming across settings, connection rows, file trees, and terminal surfaces
  • Adds new contracts for DPoP failure categories, desktop app activation, provider setup/installation, assistant citations, and browser profiles; adds database migrations 041–047
  • Risk: resolveSessionCookieName in utils.ts now derives cookie names from environment identity for remote non-development servers; existing sessions on those servers will be invalidated. model.MODEL_SLUG_ALIASES_BY_PROVIDER in model.ts removes Claude slug aliases, which may affect custom model resolution for users relying on alias-based slug lookups. SQLite busy_timeout is now 5,000ms in Sqlite.ts; workloads previously failing fast on lock contention will now wait instead.

Macroscope summarized 85d5cfc.

@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: c069c447-7e73-4396-a18c-e94877427bc6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 changed lines (additions + deletions). label Jul 17, 2026
@maxwellyoung
maxwellyoung marked this pull request as ready for review July 17, 2026 22:41
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 17, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The implementation is a small, localized UI fix that makes completed assistant copy actions visible without changing copy-state or data behavior. An unresolved comment identifies a concrete regression-test assertion that can pass even if hover gating returns, so human attention is warranted.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the codex/fix-assistant-copy-button-visibility branch from 1479e5d to 89af03c Compare August 15, 2026 11:02

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small follow-ups on the assistant footer visibility change: an orphaned group/assistant marker and an assertion that cannot fail.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/chat/MessagesTimeline.tsx Outdated
Comment thread apps/web/src/components/chat/MessagesTimeline.test.tsx Outdated
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Sep 5, 2026
@maxwellyoung maxwellyoung changed the title [codex] keep completed assistant copy actions visible fix(web): keep completed assistant copy actions visible Sep 5, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 5, 2026 08:30

Dismissing prior approval to re-evaluate 85d5cfc

@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Sep 5, 2026
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting).

This review would cost an estimated $308.16, which exceeds your per-review limit of $10.00.

The top 3 files driving up this estimate:

File Diff Size Estimate
apps/web/src/components/chat/ChatComposer.tsx 218.09KB $10.90
apps/web/src/components/ChatView.tsx 192.11KB $9.61
apps/server/src/provider/Layers/OpenCodeAdapter.ts 127.24KB $6.36

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude the file(s) above from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

@t3dotgg

t3dotgg commented Sep 6, 2026

Copy link
Copy Markdown
Member

Note

🤖 Codex responding on behalf of Theo

Closing this for now because the reporter confirmed that #4046 no longer occurs, and we are keeping the current footer visibility behavior. Thank you for working on copy access and for providing the before/after recording and test results. If the copy action still becomes inaccessible on current main, or we have misunderstood what your change fixes, please reopen this PR or leave a comment so we can reopen it.

@t3dotgg t3dotgg closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: copy button goes invisible

2 participants