fix(web): keep completed assistant copy actions visible - #4107
maxwellyoung wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The implementation is a small, localized UI fix that makes completed assistant copy actions visible without changing copy-state or data behavior. An unresolved comment identifies a concrete regression-test assertion that can pass even if hover gating returns, so human attention is warranted. You can add or adjust custom eligibility rules. Learn more. |
1479e5d to
89af03c
Compare
There was a problem hiding this comment.
Two small follow-ups on the assistant footer visibility change: an orphaned group/assistant marker and an assertion that cannot fail.
Posted via Macroscope — UI Consistency
…visibility' into codex/copy-footer-refresh-20260905
Dismissing prior approval to re-evaluate 85d5cfc
|
Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting). This review would cost an estimated $308.16, which exceeds your per-review limit of $10.00. The top 3 files driving up this estimate:
Tip To get this pull request reviewed, you can:
|
|
Note 🤖 Codex responding on behalf of Theo Closing this for now because the reporter confirmed that #4046 no longer occurs, and we are keeping the current footer visibility behavior. Thank you for working on copy access and for providing the before/after recording and test results. If the copy action still becomes inaccessible on current main, or we have misunderstood what your change fixes, please reopen this PR or leave a comment so we can reopen it. |
Completed assistant responses hide their copy action when the pointer leaves the row, including after selecting response text. Keep the shared assistant footer visible and remove its unused hover group and visibility toggle.
Fixes #4046.
Validation: 142 focused timeline tests pass. In the isolated local web client, selected response text and moved the pointer away: the footer disappears before the change and remains visible after it. Clicking Copy copies the complete response, including its list, rather than only the selected paragraph.
Web typechecking reports TS2554 in fileEditorVirtualization.test.ts:260. The same error occurs on unchanged main at eced382.
Before: selected response text, then moved the pointer outside the row.
After: the same selection and pointer movement leaves the copy action visible.
copy-footer-after.webm
Note
Keep completed assistant copy actions visible and harden desktop update state across re-checks
resolveSessionCookieNamein utils.ts now derives cookie names from environment identity for remote non-development servers; existing sessions on those servers will be invalidated.model.MODEL_SLUG_ALIASES_BY_PROVIDERin model.ts removes Claude slug aliases, which may affect custom model resolution for users relying on alias-based slug lookups. SQLitebusy_timeoutis now 5,000ms in Sqlite.ts; workloads previously failing fast on lock contention will now wait instead.Macroscope summarized 85d5cfc.