Skip to content

fix(desktop): restore Linux dock icon association #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbrianps wants to merge 2 commits into from
Closed

fix(desktop): restore Linux dock icon association #6250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb8c71
fix(desktop): restore Linux dock icon association
kbrianps Aug 12, 2026
cbb2392
test(desktop): cover Linux window class pre-ready
kbrianps Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion apps/desktop/src/app/DesktopPreReadyPlatform.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { HostProcessPlatform } from "@t3tools/shared/hostProcess";
import * as Context from "effect/Context";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import { beforeEach, vi } from "vite-plus/test";
import { afterEach, beforeEach, vi } from "vite-plus/test";

const { appendSwitchMock, getSwitchValueMock, hasSwitchMock, registerSchemesMock } = vi.hoisted(
() => ({
Expand Down Expand Up @@ -37,6 +37,10 @@ describe("DesktopPreReadyPlatform", () => {
registerSchemesMock.mockReset();
});

afterEach(() => {
vi.unstubAllEnvs();
});

it("reads an explicit Electron command-line switch value", () => {
const value = DesktopPreReadyPlatform.readCommandLineSwitchValue(
{
Expand Down Expand Up @@ -78,6 +82,23 @@ describe("DesktopPreReadyPlatform", () => {
assert.isNull(value);
});

it.effect("appends the packaged Linux window class before Electron is ready", () =>
Effect.gen(function* () {
vi.stubEnv("VITE_DEV_SERVER_URL", "");
hasSwitchMock.mockReturnValue(false);

const preReadyLayer = DesktopPreReadyPlatform.layer.pipe(
Layer.provide(Layer.succeed(HostProcessPlatform, "linux")),
);
const options = yield* Effect.gen(function* () {
return yield* DesktopPreReadyPlatform.DesktopPreReadyElectronOptions;
}).pipe(Effect.provide(preReadyLayer));

assert.equal(options.linux?.linuxWmClass, "t3code");
assert.deepEqual(appendSwitchMock.mock.calls[0], ["class", "t3code"]);
}),
);

it.effect(
"acquires a synchronous pre-ready layer before an asynchronous Clerk-shaped layer",
() =>
Expand Down
Loading