Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped server bug fix that prevents remote tag conflicts from breaking worktree branch refreshes, while preserving the branch update behavior the caller needs. An integration test covers the prune configuration scenario and confirms local tags remain unchanged. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
This is urgently needed. |
Dismissing prior approval to re-evaluate a61f4f8
|
Note Written by Hi! We are cleaning up open PRs, and this one appears to have been created with an older model ( |
Worktree preparation refreshes remote branches with
git fetch, but that command inherits global tag-pruning configuration. If a local tag differs from its remote tag, the branch refresh fails withwould clobber existing tageven though T3 Code does not need tags for the worktree.This explicitly disables tag fetching and tag pruning for the remote refresh. A regression test enables
fetch.pruneTags, moves a remote tag, and verifies the tracking branch updates without changing the local tag.Tests:
vp test run apps/server/src/vcs/GitVcsDriverCore.test.ts(50 passed)pnpm --filter t3 typecheckBuilt with OpenAI Codex using GPT-5.
Note
Pass
--no-tagsand--no-prune-tagstoGitVcsDriverCore.fetchRemoteForces the git fetch call in GitVcsDriverCore.ts to skip fetching and pruning tags, overriding any user-level
fetch.prune/fetch.pruneTagsconfig. Adds an integration test in GitVcsDriverCore.test.ts confirming remote-tracking branches update while local tags stay unchanged.fetchRemoteno longer updates or prunes tags; callers relying on tag updates during remote fetch must do so separately.Macroscope summarized a61f4f8.