Repository navigation
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds persisted custom CLI-path configuration and threads it through discovery, authentication probes, remote refinement, and source-control operations for three providers. Existing defaults are preserved and tests cover the new paths, but the cross-cutting production behavior and new user-facing capability merit human review. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Note 🤖 GPT-6 Astra responding on behalf of Theo We're closing this as part of a cleanup of stale PRs. Thank you for the time and care you put into this contribution. A local merge check found conflicts in 7 files against the current target branch. The latest implementation commit is from 2026-09-04, and there has been no contribution update in over a week. At this point, regenerating a focused patch against the current intended base would be easier to review and maintain than updating this PR. We appreciate the work and will keep this thread as a reference. If you revisit it, please check the current direction with us and link the fresh PR back here. |
Source-control integrations currently spawn
gh,glab, andazby command name. When these tools are installed through a version manager or outside the server's inherited PATH, T3 Code reports them as unavailable and cannot run source-control operations.This adds server-scoped binary path settings for GitHub, GitLab, and Azure DevOps. The configured executable is used consistently for discovery, authentication checks, remote refinement, and provider operations. The Source Control settings page exposes the path in each CLI provider row, while preserving
gh,glab, andazas defaults.Related to #7618.
Verification
Screenshots
Before
After
Assisted by GPT-5.6 Sol via the Codex harness in T3 Code.
Note
Add custom CLI path configuration for source-control providers
AzureDevOpsCli.make,GitHubCli.make,GitLabCli.make) to read the configured path from server settings and pass it toVcsProcess.run.SourceControlProviderRegistry.makeWithProvidersuses the configured executable during discovery; settings-read failures fall back to the default discovery specifications.Macroscope summarized db14ad9.
Note
Medium Risk
Source-control discovery and all CLI operations now depend on server settings at runtime; settings read failures fall back to default command names, which could mask misconfiguration on constrained deployments.
Overview
Adds server-scoped
sourceControlProviders.*.binaryPathsettings (defaultsgh,glab,az) so GitHub, GitLab, and Azure DevOps integrations can run CLIs installed outside the server’sPATH.GitHubCli, GitLabCli, and AzureDevOpsCli now resolve the executable from
ServerSettingsServiceon each run and pass that path into process spawn and error context (unavailable messages cite the configured path, not only “on PATH”). SourceControlProviderRegistry applies the same paths to CLI discovery probes and remote refinement viaconfigureDiscoverySpecs.The Source Control settings UI adds a CLI executable field on each CLI provider row (primary environment only), with trim-on-save and blank → default behavior covered in server settings tests. User docs note setting the path and rescanning when needed.
Reviewed by Cursor Bugbot for commit db14ad9. Bugbot is set up for automated code reviews on this repo. Configure here.