feat: add EnumCaseNameSniff - #30
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Unresolved moderate issues affect underscore validation and functional test correctness.
Review effort: Lite
Findings: None
What changed in this PR
Adds a PHPCS sniff enforcing strict PascalCase enum case names, with tests, ruleset registration, and changelog documentation.
Changes:
- Implements
EnumCaseNameSniff. - Adds enum fixtures and functional coverage.
- Enables the sniff in the PHP 8.4 ruleset.
- Documents the feature.
| File | Summary |
|---|---|
tests/Functional/EnumCaseNameTest.php |
Functional tests; moderate issues with expected exit code and incomplete line coverage assertions. |
tests/Functional/EnumCaseName/Enums.php |
Provides valid and invalid enum cases. |
src/PixelFederationCodingStandard/Sniffs/Classes/EnumCaseNameSniff.php |
Implements enum case validation; moderate issue allowing underscores. |
phpcs.ruleset.84.xml |
Enables the sniff. |
CHANGELOG.md |
Documents the new sniff. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dzoudzou
approved these changes
Sep 22, 2026
dzoudzou
requested changes
Sep 22, 2026
dzoudzou
approved these changes
Sep 22, 2026
dzoudzou
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.